Skip to content

Missing npmrc for other extensions #13408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Missing npmrc for other extensions #13408

merged 2 commits into from
Mar 24, 2025

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Mar 24, 2025

I saw a warning in the last build for the extension pack that we're not linked to CFS for these extensions. These extensions don't actually download any node modules, but adding these configs should make the warnings go away.

@bobbrow bobbrow requested a review from a team as a code owner March 24, 2025 17:12
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Mar 24, 2025
sean-mcmanus
sean-mcmanus previously approved these changes Mar 24, 2025
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the always-auth deprecation: #13377

@bobbrow
Copy link
Member Author

bobbrow commented Mar 24, 2025

What about the always-auth deprecation: #13377

I thought we were going to remove it in the next npm upgrade. I suppose its value doesn't matter for these projects and I could remove it now if you want.

@sean-mcmanus
Copy link
Contributor

I thought we were going to remove it in the next npm upgrade. I suppose its value doesn't matter for these projects and I could remove it now if you want.

I think it would be better removed now.

@bobbrow bobbrow merged commit e2f90ba into main Mar 24, 2025
6 checks passed
@bobbrow bobbrow deleted the bobbrow/npmrc branch March 24, 2025 22:13
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants