Skip to content

Use SingleHost as default Netherite emulator string #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Use SingleHost as default Netherite emulator string #4530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2fd624
Add SingleHost default emulator string
MicroFish91 May 30, 2025
529ce39
Remove comment
MicroFish91 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/commands/appSettings/connectionSettings/eventHubs/EventHubsConnectionExecuteStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/

import { type ISubscriptionContext } from '@microsoft/vscode-azext-utils';
import { ConnectionKey, ConnectionType, localEventHubsEmulatorConnectionRegExp, localEventHubsEmulatorConnectionStringDefault, type ConnectionKeyValues } from '../../../../constants';
import { ConnectionKey, ConnectionType, localEventHubsEmulatorConnectionRegExp, localEventHubsEmulatorConnectionString, type ConnectionKeyValues } from '../../../../constants';
import { getLocalSettingsConnectionString } from '../../../../funcConfig/local.settings';
import { SetConnectionSettingStepBase } from '../SetConnectionSettingStepBase';
import { getEventHubsConnectionString } from '../getLocalConnectionSetting';
Expand All @@ -22,7 +22,7 @@ export class EventHubsConnectionExecuteStep<T extends IEventHubsConnectionWizard
if (currentConnection && localEventHubsEmulatorConnectionRegExp.test(currentConnection)) {
return;
}
value = localEventHubsEmulatorConnectionStringDefault;
value = localEventHubsEmulatorConnectionString;
} else {
value = (await getEventHubsConnectionString(<T & ISubscriptionContext>context)).connectionString;
}
Expand Down
6 changes: 2 additions & 4 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,9 @@ export const localhost: string = '127.0.0.1';
export const tsDefaultOutDir: string = 'dist';
export const tsConfigFileName: string = 'tsconfig.json';

export const localEventHubsEmulatorConnectionStringDefault: string = 'MemoryF';
export const localEventHubsEmulatorConnectionStringAlternate: string = 'Memory';

export const localStorageEmulatorConnectionString: string = 'UseDevelopmentStorage=true';
export const localEventHubsEmulatorConnectionRegExp: RegExp = new RegExp(`${localEventHubsEmulatorConnectionStringDefault}|${localEventHubsEmulatorConnectionStringAlternate}`);
export const localEventHubsEmulatorConnectionString: string = 'SingleHost';
export const localEventHubsEmulatorConnectionRegExp: RegExp = new RegExp(`${localEventHubsEmulatorConnectionString}|MemoryF|Memory`);

export const workerRuntimeKey: string = 'FUNCTIONS_WORKER_RUNTIME';
export const workerRuntimeVersionKey: string = 'FUNCTIONS_WORKER_RUNTIME_VERSION';
Expand Down