Skip to content

Commit

Permalink
Fix name validation for containerized function apps (#4012)
Browse files Browse the repository at this point in the history
* Fix name validation

* Change casing

* use ternary

* upgrade appservice package

* push broke

* try again
  • Loading branch information
motm32 authored Mar 20, 2024
1 parent f91a838 commit 96b2972
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1178,7 +1178,7 @@
"@azure/core-client": "^1.7.3",
"@azure/core-rest-pipeline": "^1.11.0",
"@azure/storage-blob": "^12.5.0",
"@microsoft/vscode-azext-azureappservice": "^3.1.1",
"@microsoft/vscode-azext-azureappservice": "^3.1.2",
"@microsoft/vscode-azext-azureappsettings": "^0.2.1",
"@microsoft/vscode-azext-azureutils": "^3.0.0",
"@microsoft/vscode-azext-serviceconnector": "^0.1.3",
Expand Down
4 changes: 2 additions & 2 deletions src/tree/SubscriptionTreeItem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ export class SubscriptionTreeItem extends SubscriptionTreeItemBase {
const promptSteps: AzureWizardPromptStep<IAppServiceWizardContext>[] = [];
const executeSteps: AzureWizardExecuteStep<IAppServiceWizardContext>[] = [];

promptSteps.push(new SiteNameStep("functionApp"));

const storageAccountCreateOptions: INewStorageAccountDefaults = {
kind: StorageAccountKind.Storage,
performance: StorageAccountPerformance.Standard,
Expand All @@ -118,6 +116,8 @@ export class SubscriptionTreeItem extends SubscriptionTreeItemBase {

await detectDockerfile(context);

promptSteps.push(new SiteNameStep(context.dockerfilePath ? "containerizedFunctionApp" : "functionApp"));

if (context.dockerfilePath) {
const containerizedfunctionAppWizard = await createContainerizedFunctionAppWizard();
promptSteps.push(...containerizedfunctionAppWizard.promptSteps);
Expand Down

0 comments on commit 96b2972

Please sign in to comment.