Skip to content

Update from Library.Template - #429

Merged
Andrew Arnott (AArnott) merged 39 commits into
mainfrom
aarnott-library-template-update-d39
Nov 3, 2026
Merged

Andrew Arnott (AArnott) merged 39 commits into
mainfrom
aarnott-library-template-update-d39

Conversation

@AArnott

Copy link
Copy Markdown
Member

Refresh the repository from the latest Library.Template microbuild branch to pick up current tooling, SDK, CI, documentation, and test traversal improvements.

Preserve repository-specific configuration and NativeAOT test traversal while resolving merge conflicts. TUnit.Engine is pinned to 1.76.28, the highest version available on the configured feed. Updated StyleCop diagnostics are addressed without suppressing the new warnings.

Validation: dotnet restore, dotnet build (0 warnings, 0 errors), and tools/dotnet-test-cloud.ps1 (231 passed).

renovate Bot and others added 30 commits October 10, 2026 07:40
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This group was undoing policies made in earlier-defined package rules.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… (604)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate Bot and others added 7 commits October 25, 2026 13:49
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Resolve Renovate, package, SDK, and test traversal conflicts while retaining repo-specific settings; pin TUnit.Engine to 1.76.28, the highest version available on the configured feed. Apply fixes required by the updated StyleCop analyzer.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 23:52
@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.88%. Comparing base (ed1dc41) to head (478a717).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   77.88%   77.88%           
=======================================
  Files          14       14           
  Lines         859      859           
  Branches      224      224           
=======================================
  Hits          669      669           
  Misses        126      126           
  Partials       64       64           
Flag Coverage Δ
Linux 79.18% <100.00%> (ø)
Windows 77.88% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

SA1504 is suppressed as a hidden diagnostic despite the no-suppression claim, and the documented test commands use paths that fail from the instructed project directory.

2 open issues
What changed in this PR

Refreshes the repository from Library.Template with updated tooling, CI authentication, documentation settings, and NativeAOT test traversal adjustments.

Changes:

  • Updates the .NET SDK, PowerShell, test packages, and StyleCop, with corresponding C# style changes.
  • Adds Azure Artifacts authentication to Copilot setup and adjusts NativeAOT publishing metadata and symbol filtering.
  • Centralizes link-checker settings and updates documentation configuration and contributor guidance.
File Description
tools/​Get-SymbolFiles.ps1 Classifies NativeAOT compatibility symbols as test-related.
test/​Microsoft.VisualStudio.Validation.Tests/​RequiresTests.cs Updates pointer-validation tests to native-integer syntax.
test/​dirs.proj Adjusts framework and publishing metadata for NativeAOT tests.
src/​Microsoft.VisualStudio.Validation/​Verify.cs Uses a native-integer cast for the HRESULT sentinel.
src/​Microsoft.VisualStudio.Validation/​Requires.cs Uses nint syntax and updates zero-value documentation.
src/​Microsoft.VisualStudio.Validation.Analyzers.CodeFixes/​CSharpUseRequiresGuardsCodeFixProvider.cs Adds trailing commas to property patterns.
global.json Updates the .NET SDK pin.
docfx/​docfx.json Suppresses NuGet audit warnings during metadata extraction.
docfx/​.editorconfig Defines DocFX JSON indentation.
Directory.Packages.props Updates testing, MicroBuild, assertion, and StyleCop packages.
CONTRIBUTING.md Documents link checking and DocFX audit-warning handling.
.mlc.toml Centralizes link-checker exclusions and redirect settings.
.github/​workflows/​docs_validate.yml Removes inline link-checker settings in favor of shared configuration.
.github/​workflows/​copilot-setup-steps.yml Adds Azure login and package-feed credential setup.
.editorconfig Sets SA1504 diagnostic severity to silent.
.config/​dotnet-tools.json Updates the PowerShell tool version.
.agents/​skills/​testing/​SKILL.md Expands test execution and working-directory guidance.

Review effort: Balanced

Comment thread .editorconfig Resolved
Comment thread .agents/skills/testing/SKILL.md Resolved
Keep SA1504 enabled and make project-local test examples use valid relative project paths.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 00:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

CONTRIBUTING.md references a nonexistent workflow file instead of azure-pipelines/dotnet.yml, where the nonfatal audit-warning policy is actually configured.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Low severity Point to the actual CI audit-warning policy file

CONTRIBUTING.md:79

The referenced .github/workflows/build.yml does not exist in this repository. The nonfatal audit-warning policy is configured by -warnNotAsError in azure-pipelines/dotnet.yml (lines 12 and 19). Point to that file so contributors can find the actual CI policy.

2 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 3, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human judgment is needed to assess whether the unpublished nit about an incorrect CI-policy reference should affect approval.

No open issues 🎉

Review effort: Balanced

@AArnott
Andrew Arnott (AArnott) merged commit 0002e29 into main Nov 3, 2026
11 checks passed
@AArnott
Andrew Arnott (AArnott) deleted the aarnott-library-template-update-d39 branch November 3, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants