Add spector case for extensible enum with special word member names#9785
Add spector case for extensible enum with special word member names#9785
Conversation
…ames Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
…n/json Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
|
@copilot check all changes of the PR to make sure they are consistent. |
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Reviewed all changes for consistency in f70bb68. Found and fixed one issue: the
Build passes with 61 valid scenarios. |
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
commit: |
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
Show changes |
|
You can try these changes here
|
|
@copilot fix ci error: |
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
| /** | ||
| * Verify enum member names that are special words using extensible enum (union). | ||
| */ | ||
| union Enum { |
There was a problem hiding this comment.
| union Enum { | |
| union OpenStringUnion { |
or ExtensibleString
as this is not an enum and would block an actual enum test
There was a problem hiding this comment.
@copilot rename union Enum to ExtensibleString. And DO update all related code and doc after rename.
There was a problem hiding this comment.
Renamed union Enum to union ExtensibleString and updated all references in the operation signature in 1eb659f.
There was a problem hiding this comment.
@copilot Also update namespace/interface/route/...
There was a problem hiding this comment.
Renamed interface Enums → ExtensibleStrings, route /enums → /extensible-strings, and operation putEnumValue → putExtensibleStringValue. Updated mockapi.ts scenario name/URI and regenerated spec-summary.md accordingly in 3efd8b8.
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…viewer feedback Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
special-words/main.tsp@putoperation per reviewer feedbackExtensibleStringreturn type so mock API echoes back the sent valueputExtensibleStringValue(@body body: ExtensibleString): ExtensibleString;@docdecorators from union definition for consistency with rest of fileunion Enumtounion ExtensibleStringto avoid blocking actual enum testsEnumstoExtensibleStrings, route/enumsto/extensible-strings, and operationputEnumValuetoputExtensibleStringValue✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.