report nice error message when dotnet is not installed or not valid#5477
Merged
chunyu3 merged 34 commits intomicrosoft:mainfrom Jan 22, 2025
Merged
report nice error message when dotnet is not installed or not valid#5477chunyu3 merged 34 commits intomicrosoft:mainfrom
chunyu3 merged 34 commits intomicrosoft:mainfrom
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
archerzz
approved these changes
Jan 3, 2025
JoshLove-msft
requested changes
Jan 7, 2025
Contributor
JoshLove-msft
left a comment
JoshLove-msft
left a comment
There was a problem hiding this comment.
Added a few questions
chunyu3
changed the title
JoshLove-msft
previously requested changes
Jan 14, 2025
Contributor
JoshLove-msft
left a comment
JoshLove-msft
left a comment
There was a problem hiding this comment.
Added a few additional comments, but overall looks like a nice improvement to the UX.
jsquire
requested changes
Jan 15, 2025
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
jsquire
previously requested changes
Jan 17, 2025
packages/http-client-csharp/emitter/test/Unit/dotnet-sdk-validation.test.ts
Show resolved
Hide resolved
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
jsquire
reviewed
Jan 21, 2025
Member
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
LGTM. I'll clear my request for changes and let @JoshLove-msft make the final decision on when to move forward.
chunyu3
dismissed
JoshLove-msft’s stale review
the comments are all resolved.
JoshLove-msft
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5364
invalid-dotnet-sdk-dependencydiagnostic