[http-client-csharp] Fix explode object query parameter serialization#11124
Merged
JoshLove-msft merged 1 commit intoJul 1, 2026
Merged
Conversation
…property entries A model-typed query parameter marked with @query(#{ explode: true }) was serialized via the object's ToString, producing the type name in the URL (e.g. ?filter=Namespace.FilterOptions). Expand such parameters into one query entry per property using the property's wire name (RFC 6570 form explode, e.g. ?field=status&value=active). Nested objects and collections fall back to the previous behavior pending a separate design decision. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
commit: |
Contributor
|
No changes needing a change description found. |
jorgerangel-msft
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11123
Problem
A model-typed query parameter marked with
@query(#{ explode: true })was serialized via the object'sToString, producing the type name in the URL:Fix
RestClientProvider.BuildAppendQueryStatementnow expands a model-typedexplodequery parameter into one query entry per property, using each property's wire name (RFC 6570 form explode):Models whose properties are all simple scalars/enums are expanded. Nested objects and collections fall back to the previous behavior pending a separate design decision (they are not defined by RFC 6570 form explode).
Tests
TestBuildCreateRequestMethodWithExplodedModelQueryParameterunit test.RestClientProviderTestspass (no regressions).The end-to-end Spector scenario and C# Spector test that exercise this against a live mock server are in a follow-up PR (the shared
@typespec/http-specsscenario + generated client).