add a couple of missing options to be parsed #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As things are, tsgo basically ignores these fields in my tsconfig. Could there be a "default: panic" or similar in this switch? That'd presumably help make this kind of bug less easy to come up again.
srabraham
added a commit
to srabraham/typescript-go
that referenced
this pull request
Apr 30, 2025
This is a more comprehensive fix than microsoft#838. Future work would involve doing the same sort of tests for non-Tristate types.
srabraham
added a commit
to srabraham/typescript-go
that referenced
this pull request
Apr 30, 2025
This is a more comprehensive fix than microsoft#838. Future work would involve doing the same sort of tests for non-Tristate types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As things are, tsgo basically ignores these fields in a tsconfig, so rewriting imports doesn't work.
Could there be a "default: panic" or similar in this switch? Or some test? That'd presumably help make this kind of bug less easy to come up again.
EDIT: This PR is mutually incompatible with my other one, #839. If #839 makes sense, I suggest you merge that one and close #838.