Implement auto-import code actions, port tests and fix some bugs #2053
Conversation
This reverts commit 8132a8c.
There was a problem hiding this comment.
Pull Request Overview
This PR implements auto-import fix functionality (code actions) for the TypeScript language server port. It adds support for generating quick-fix code actions that automatically add missing import statements when identifiers cannot be found.
Key changes:
- New code actions handler that detects import-related diagnostics and suggests fixes
- LSP server integration for the
textDocument/codeActionrequest - Enhanced test infrastructure to support fourslash tests with implicit first files
- Utility function to check symbol meaning compatibility
Reviewed Changes
Copilot reviewed 170 out of 170 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/ls/codeactions.go |
New file implementing code action provider with auto-import fix logic |
internal/lsp/server.go |
Registers code action handler and advertises capability to clients |
internal/ls/utilities.go |
Adds symbolFlagsHaveMeaning helper for filtering exports by semantic meaning |
internal/testrunner/test_case_parser.go |
Adds support for implicit first file in fourslash tests |
internal/fourslash/fourslash.go |
Implements VerifyImportFixAtPosition test method |
internal/fourslash/test_parser.go |
Updates parser to use new implicit first file option |
internal/fourslash/_scripts/convertFourslash.mts |
Adds conversion support for importFixAtPosition verification |
internal/fourslash/_scripts/failingTests.txt |
Tracks test status (many still failing as noted in PR description) |
| Multiple test files | Adds 160+ fourslash tests for import fix scenarios |
| TestCompletionsImportOrExportSpecifier | ||
| TestCompletionsImport_default_alreadyExistedWithRename | ||
| TestCompletionsImport_default_anonymous | ||
| TestCompletionsImport_default_symbolName |
There was a problem hiding this comment.
A smattering of bugfixes as I looked at failing auto-import fix tests caused other existing tests to pass.
andrewbranch
left a comment
andrewbranch
left a comment
There was a problem hiding this comment.
Thought I was having severe deja vu 😄
| } | ||
|
|
||
| // getExportInfos searches for exports (from importFixes.ts) | ||
| func getExportInfos( |
There was a problem hiding this comment.
Duplicated with (*LanguageService).getExportInfos?
There was a problem hiding this comment.
Technically, no, I think; the the existing one should have been called getExportInfoMap
|
|
|
Going to merge this now just to get this out. It's going to be no worse than the fixes that completions give, and both will improve as we fix bugs. |
Fixes #1658
This is not perfect. It passes maybe 60 out of 160 ported fourslash tests so far. Many issues exist with import sorting or formatting, and there are other diagnostics fixed by import fixes that are not being addressed here (like swapping a non-type to a type), and there are other auto-imports that seem weird that I need to double check.But for the typical cases of just missing an import, this seems to work.Re-ported a bunch of code and it's now passing tests except these differences:
@importdoesn't work (we see the reparsed nodes...)