infra: Support easy trident binary building on ubuntu 24 #461
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frhuelsz
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces support for building Trident binaries for Azure Linux 3 (AzL3) on Ubuntu 24, addressing library compatibility issues between newer Ubuntu versions and AzL3. It adds a containerized build process using an AzL3 base image and automatic OS detection to select the appropriate binary for local testing.
Changes:
- Added Docker-based build infrastructure for Azure Linux 3 compatibility
- Modified download service to fetch the AzL3-specific binary
- Enhanced Makefile with OS detection to automatically select correct binary for testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packaging/docker/Dockerfile.azl3-builder | New Dockerfile defining AzL3 builder image with build dependencies and pre-fetched cargo packages |
| Makefile | Added azl3-builder-image, build-azl3, and bin/trident-azl3 targets; added OS detection logic for run-netlaunch to select appropriate binary |
| tests/images/trident-mos/files/download-trident.service | Updated curl command to download trident-azl3 instead of trident |
bfjelds
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
In the past we were doing tricks to locally build trident and then use it in AzL3. However, Ubuntu 24 has newer libs than AzL, meaning that the trick no longer works well.
This PR introduces a minute middle step to build the binary in a short-lived azl3 container so that we can still get a relatively quick build that is 100% compatible with AzL3.
The makefile also adds detection so that
make run-netlaunchgrabs the simple build when possible, and does the container build when needed.The container image needs to be created once (takes a couple minutes) and then can be started quickly just for a build. Crates are prefetched for convenience.