Skip to content

Conversation

@frhuelsz
Copy link
Contributor

@frhuelsz frhuelsz commented Jan 9, 2026

🔍 Description

Closes #403

  • Adds code and makefile targets to build bin/rcp-proxy, the proxy component of a reverse-connect proxy setup.
  • Add a client library for an RCP client.
  • Adds all common logic for RCP TLS connections.

@frhuelsz frhuelsz self-assigned this Jan 9, 2026
Copilot AI review requested due to automatic review settings January 9, 2026 05:35
@frhuelsz frhuelsz requested a review from a team as a code owner January 9, 2026 05:35
@frhuelsz frhuelsz moved this from Backlog to In review in Trident gRPC API Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds infrastructure for a reverse-connect proxy (RCP) system that enables secure communication between a proxy and client over TLS. The proxy component connects to a client listener, then forwards traffic between the client and a Unix socket server.

Key changes:

  • Implements TLS certificate generation and embedding for mutual TLS authentication
  • Adds rcp-proxy binary that connects to an RCP client and forwards traffic to a Unix socket
  • Provides a client library for accepting reverse connections from the proxy

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tools/pkg/rcp/tlscerts/generate.go Standalone tool to generate self-signed TLS certificates for testing
tools/pkg/rcp/tlscerts/certs.go Common functions to access embedded certificate data
tools/pkg/rcp/tlscerts/keyserver.go Server-side certificate loading (build tag: tls_server)
tools/pkg/rcp/tlscerts/keyclient.go Client-side certificate loading (build tag: tls_client)
tools/pkg/rcp/tlscerts/.gitignore Excludes generated certificate files from git
tools/pkg/rcp/proxy/proxy.go Implements reverse-connect proxy logic with TLS and bidirectional traffic forwarding
tools/pkg/rcp/client/listen.go Client library for accepting TLS connections from the proxy
tools/pkg/rcp/harpoon.go Defines default Unix socket path constant
tools/cmd/rcp-proxy/main.go CLI entry point for the rcp-proxy binary
.vscode/settings.json Adds build tags for Go tooling support

Copilot AI review requested due to automatic review settings January 9, 2026 06:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 9, 2026 08:31
frhuelsz and others added 4 commits January 9, 2026 00:33
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 12, 2026 18:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 12, 2026 21:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Copilot AI review requested due to automatic review settings January 12, 2026 22:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 13 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 12, 2026 22:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

frhuelsz and others added 2 commits January 12, 2026 15:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 12, 2026 23:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

@frhuelsz frhuelsz merged commit 3ea12c2 into main Jan 21, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Trident gRPC API Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

RFC 0379: gRPC API: Reverse-Connect Proxy

3 participants