Refactor Assert.Contains APIs #7075
Merged
+584
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
reviewed
Dec 8, 2025
Member
nohwnd
left a comment
nohwnd
left a comment
There was a problem hiding this comment.
tests look great! (event though the error messages need a lot of improvement - as mentioned in other place).
Are the localization changes on purpose?
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.es.xlf
Outdated
Show resolved
Hide resolved
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ja.xlf
Outdated
Show resolved
Hide resolved
Evangelink
commented
Dec 9, 2025
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.es.xlf
Outdated
Show resolved
Hide resolved
Evangelink
commented
Dec 9, 2025
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.it.xlf
Outdated
Show resolved
Hide resolved
Evangelink
commented
Dec 9, 2025
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ja.xlf
Outdated
Show resolved
Hide resolved
Evangelink
commented
Dec 9, 2025
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ko.xlf
Outdated
Show resolved
Hide resolved
Evangelink
commented
Dec 9, 2025
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.pl.xlf
Outdated
Show resolved
Hide resolved
Evangelink
commented
Dec 9, 2025
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hans.xlf
Outdated
Show resolved
Hide resolved
Evangelink
commented
Dec 9, 2025
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hant.xlf
Outdated
Show resolved
Hide resolved
fhnaseer
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #6732 where I am validating more cases around
null. As part of it, I am also ensuring we have uniform behavior when passingnullfor the objects not expecting to benull.