[C#] feat: Implement GetTokenOrStartSignInAsync method public interface
#987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhk97
requested review from
swatDong,
kuojianlu and
lilyydu
as code owners
singhk97
added a commit
that referenced
this pull request
Dec 6, 2023
…face (#987) ## Linked issues closes: #894 (issue number) ## Details - Rename `TeamsAIAuthException` to `AuthException` - Rename `TeamsAIAuthReason` to `AuthExceptionReason` - Implement helper methods in `AuthUtilities` - Implement `GetTokenOrStartSignInAsync`. - Add `IsUserSignedIn` to `IAuthentication` interface - this is needed so it can be called in the `Application` class. - Make `AuthenticationManager._default` private property public `Default`. ## Attestation Checklist - [x] My code follows the style guidelines of this project - I have checked for/fixed spelling, linting, and other errors - I have commented my code for clarity - I have made corresponding changes to the documentation (we use [TypeDoc](https://typedoc.org/) to document our code) - My changes generate no new warnings - I have added tests that validates my changes, and provides sufficient test coverage. I have tested with: - Local testing - E2E testing in Teams - New and existing unit tests pass locally with my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #894 (issue number)
Details
TeamsAIAuthExceptiontoAuthExceptionTeamsAIAuthReasontoAuthExceptionReasonAuthUtilitiesGetTokenOrStartSignInAsync.IsUserSignedIntoIAuthenticationinterface - this is needed so it can be called in theApplicationclass.AuthenticationManager._defaultprivate property publicDefault.Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (we use TypeDoc to document our code)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes