Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] chore: Remove questbot #962

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

singhk97
Copy link
Collaborator

Linked issues

closes: #959 (issue number)

Details

  • Remove quest bot since it's not ready for the next release. In the future we can decide to add it back by finding it in the commit history.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@singhk97 singhk97 requested review from a team, swatDong, kuojianlu and lilyydu as code owners November 30, 2023 23:50
@singhk97 singhk97 merged commit 7a2761e into breaking-changes-2 Nov 30, 2023
5 checks passed
@singhk97 singhk97 deleted the kavin/remove-questbox-c# branch November 30, 2023 23:53
@singhk97 singhk97 mentioned this pull request Dec 1, 2023
singhk97 added a commit that referenced this pull request Dec 6, 2023
## Linked issues

closes: #959  (issue number)

## Details

- Remove quest bot since it's not ready for the next release. In the
future we can decide to add it back by finding it in the commit history.

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
@lilyydu lilyydu mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant