[C#] refactor: fix warnings and issues in code #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackchoey
requested review from
singhk97,
swatDong,
kuojianlu and
lilyydu
as code owners
blackchoey
changed the title
singhk97
approved these changes
Nov 30, 2023
singhk97
pushed a commit
that referenced
this pull request
Dec 6, 2023
## Linked issues closes: #861 ## Details 1. Fix warnings in the code 2. Add cancellation token parameter to interface 3. Mark bot/message extension/adaptive card base class as internal - we can change them to public in the future if we want to developers to leverage them. For now, they should be internal implementation. 4. Add `Async` to function names 5. Remove `TeamsSsoAdaptiveCardAuthentication` class as it's not supported temporary 6. Fix a bug that cannot read token from MSAL OBO token cache by using the `ILongRunningWebApi` interface 7. Fix a bug that token exchange route selector may throw exception ## Attestation Checklist - [x] My code follows the style guidelines of this project - I have checked for/fixed spelling, linting, and other errors - I have commented my code for clarity - I have made corresponding changes to the documentation (we use [TypeDoc](https://typedoc.org/) to document our code) - My changes generate no new warnings - I have added tests that validates my changes, and provides sufficient test coverage. I have tested with: - Local testing - E2E testing in Teams - New and existing unit tests pass locally with my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #861
Details
Asyncto function namesTeamsSsoAdaptiveCardAuthenticationclass as it's not supported temporaryILongRunningWebApiinterfaceAttestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (we use TypeDoc to document our code)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes