[C#] feat: add teams sso implementation #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackchoey
requested review from
singhk97,
swatDong,
kuojianlu and
lilyydu
as code owners
singhk97
approved these changes
Nov 29, 2023
singhk97
pushed a commit
that referenced
this pull request
Dec 6, 2023
## Linked issues closes: #861 ## Details 1. Implement token exchange and sign in logic for Teams SSO auth implementation 2. Updated the `IAuthentication` interface to initialize after `Application` instance is created - the authentication classes has dependency to `Application` when initialize 3. Change visibility of some classes to `internal` 4. Update the namespace of authentication classes to `Microsoft.Teams.AI` to align with other classes under the `Application` folder ## Attestation Checklist - [x] My code follows the style guidelines of this project - I have checked for/fixed spelling, linting, and other errors - I have commented my code for clarity - I have made corresponding changes to the documentation (we use [TypeDoc](https://typedoc.org/) to document our code) - My changes generate no new warnings - I have added tests that validates my changes, and provides sufficient test coverage. I have tested with: - Local testing - E2E testing in Teams - New and existing unit tests pass locally with my changes ### Additional information Because some classes from botbuilder cannot be mocked, the UT for the new code is some kind of blocked. I have finished manual testing against the code. Will follow up with the UT problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #861
Details
IAuthenticationinterface to initialize afterApplicationinstance is created - the authentication classes has dependency toApplicationwhen initializeinternalMicrosoft.Teams.AIto align with other classes under theApplicationfolderAttestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (we use TypeDoc to document our code)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes
Additional information
Because some classes from botbuilder cannot be mocked, the UT for the new code is some kind of blocked. I have finished manual testing against the code. Will follow up with the UT problem.