Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo] docs: Fix the way the beforeTurn event is registered in JS #2003

Merged
merged 2 commits into from
Sep 11, 2024
Merged

[repo] docs: Fix the way the beforeTurn event is registered in JS #2003

merged 2 commits into from
Sep 11, 2024

Conversation

Benjiiim
Copy link
Contributor

@Benjiiim Benjiiim commented Sep 11, 2024 •
edited
Loading

#minor

corinagum
corinagum requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the PR! I left one small change request, could you add that in please? Thanks!

@Benjiiim
Copy link
Contributor Author

Done.

corinagum
corinagum approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@corinagum corinagum merged commit 1e36ede into microsoft:main Sep 11, 2024
4 checks passed
@Benjiiim Benjiiim deleted the patch-4 branch September 11, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjiiim @corinagum