Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] feat: Streaming - ChefBot Sample #1965

Merged
merged 5 commits into from
Aug 30, 2024
Merged

[JS] feat: Streaming - ChefBot Sample #1965

merged 5 commits into from
Aug 30, 2024

Conversation

lilyydu
Copy link
Contributor

@lilyydu lilyydu commented Aug 29, 2024

Linked issues

closes: #1964
pending on: #1940

Details

Modifies existing ChefBot sample to display streaming.

Requirements:

  • use default augmentation
  • use a model that support streaming
  • in index.ts, update OpenAIModel declaration to configure stream: true
  • in index.ts, set informative message in ActionPlanner declaration via startStreamingMessage

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@lilyydu lilyydu marked this pull request as ready for review August 30, 2024 16:25
corinagum
corinagum previously approved these changes Aug 30, 2024
@corinagum corinagum merged commit bf7b9b1 into main Aug 30, 2024
10 checks passed
@corinagum corinagum deleted the lilyydu/js-streaming branch August 30, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JS] Streaming - Sample
2 participants