-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] feat: add helper functions to to get Teams channels, members, and details #1949
Conversation
could you also add unit tests for the new code? thanks! |
Thanks @corinagum, some unit tests are added for the codes. Please help to review, thanks! |
@yiqing-zhao Thank you! Internally we are discussing some structural strategies that would affect these changes so this PR may not be merged immediately until we finalize on those decisions. We might need to iterate on your changes before merge as well, but we appreciate the contribution! I'll update this thread as more information becomes available. |
Hey @corinagum have those discussions been finalized? |
Linked issues
closes: #minor
Details
Provide a list of your changes here. If you are fixing a bug, please provide steps to reproduce the bug.
Change details
PM Contact: @MuyangAmigo
code snippets:
To use the APIs:
screenshots:
![image](https://private-user-images.githubusercontent.com/45935381/358983789-a0317b50-dff4-429a-89dd-832cfe95d3f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDY0MjcsIm5iZiI6MTczOTU0NjEyNywicGF0aCI6Ii80NTkzNTM4MS8zNTg5ODM3ODktYTAzMTdiNTAtZGZmNC00MjlhLTg5ZGQtODMyY2ZlOTVkM2Y0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1MTUyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2M2I0MTgzZDQ2NjgxZThmODM2ODhmMmJiODQ1ODllNTVkNjM4OTVlMWQ5OTEyODg4MDVhNDNiMDI0NTM3MzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hpwnqr1zGq2-8DXjpkCUFSaqZNrvcL8qg3nuBfjOlZM)
Results are printed as belows, furthur
Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes
Additional information