Skip to content

[repo] fix: app name suffix pattern #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"outline": "outline.png"
},
"name": {
"short": "EchoBot-${{TEAMSFX_ENV}}",
"short": "EchoBot${{APP_NAME_SUFFIX}}",
"full": "Full name for EchoBot"
},
"description": {
Expand Down
4 changes: 3 additions & 1 deletion dotnet/samples/01.messaging.echoBot/env/.env.dev
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ BOT_ID=
TEAMS_APP_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=
BOT_DOMAIN=
TEAMS_APP_TENANT_ID=
TEAMS_APP_TENANT_ID=

APP_NAME_SUFFIX=dev
4 changes: 2 additions & 2 deletions dotnet/samples/01.messaging.echoBot/teamsapp.local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: EchoBot-${{TEAMSFX_ENV}}
name: EchoBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand All @@ -18,7 +18,7 @@ provision:
- uses: botAadApp/create
with:
# The Azure Active Directory application's display name
name: EchoBot-${{TEAMSFX_ENV}}
name: EchoBot${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
# The Azure Active Directory application's client id created for bot.
botId: BOT_ID
Expand Down
4 changes: 2 additions & 2 deletions dotnet/samples/01.messaging.echoBot/teamsapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: EchoBot-${{TEAMSFX_ENV}}
name: EchoBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand All @@ -21,7 +21,7 @@ provision:
- uses: botAadApp/create
with:
# The Azure Active Directory application's display name
name: EchoBot-${{TEAMSFX_ENV}}
name: EchoBot${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
# The Azure Active Directory application's client id created for bot.
botId: BOT_ID
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": "${{TEAMS_APP_ID}}",
"packageName": "com.package.name",
"name": {
"short": "NuGetSearch-${{TEAMSFX_ENV}}",
"short": "NuGetSearch${{APP_NAME_SUFFIX}}",
"full": "NuGet Search Bot"
},
"developer": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ BOT_ID=
TEAMS_APP_ID=
TEAMS_APP_TENANT_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=
BOT_DOMAIN=
BOT_DOMAIN=

APP_NAME_SUFFIX=dev
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ TEAMS_APP_ID=
TEAMS_APP_TENANT_ID=
TEAMSFX_M365_USER_NAME=
BOT_ENDPOINT=
BOT_DOMAIN=
BOT_DOMAIN=

APP_NAME_SUFFIX=local
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ provision:
# Automates the creation of a Teams app registration and saves the App ID to an environment file.
- uses: teamsApp/create
with:
name: SearchCommand-${{TEAMSFX_ENV}}
name: SearchCommand${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
teamsAppId: TEAMS_APP_ID

# Automates the creation an Azure AD app registration which is required for a bot.
# The Bot ID (AAD app client ID) and Bot Password (AAD app client secret) are saved to an environment file.
- uses: botAadApp/create
with:
name: SearchCommand-${{TEAMSFX_ENV}}
name: SearchCommand${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
botId: BOT_ID
botPassword: SECRET_BOT_PASSWORD
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ provision:
# Automates the creation of a Teams app registration and saves the App ID to an environment file.
- uses: teamsApp/create
with:
name: SearchCommand-${{TEAMSFX_ENV}}
name: SearchCommand${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
teamsAppId: TEAMS_APP_ID

# Automates the creation an Azure AD app registration which is required for a bot.
# The Bot ID (AAD app client ID) and Bot Password (AAD app client secret) are saved to an environment file.
- uses: botAadApp/create
with:
name: SearchCommand-${{TEAMSFX_ENV}}
name: SearchCommand${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
botId: BOT_ID
botPassword: SECRET_BOT_PASSWORD
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": "${{TEAMS_APP_ID}}",
"packageName": "com.package.name",
"name": {
"short": "TypeAheadBot-${{TEAMSFX_ENV}}",
"short": "TypeAheadBot${{APP_NAME_SUFFIX}}",
"full": "Type Ahead Bot"
},
"developer": {
Expand Down
3 changes: 3 additions & 0 deletions dotnet/samples/03.adaptiveCards.a.typeAheadBot/env/.env.dev
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ RESOURCE_SUFFIX=
BOT_ID=
TEAMS_APP_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=


APP_NAME_SUFFIX=dev
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ TEAMSFX_ENV=local
# Generated during provision, you can also add your own variables.
BOT_ID=
TEAMS_APP_ID=


APP_NAME_SUFFIX=local
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: TypeAheadBot-${{TEAMSFX_ENV}}
name: TypeAheadBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: TypeAheadBot-${{TEAMSFX_ENV}}
name: TypeAheadBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": "${{TEAMS_APP_ID}}",
"packageName": "com.package.name",
"name": {
"short": "TeamsChef-${{TEAMSFX_ENV}}",
"short": "TeamsChef${{APP_NAME_SUFFIX}}",
"full": "Teams Developer Chef"
},
"developer": {
Expand Down
3 changes: 3 additions & 0 deletions dotnet/samples/04.ai.a.teamsChefBot/env/.env.dev
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ BOT_ID=
TEAMS_APP_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=
BOT_DOMAIN=


APP_NAME_SUFFIX=dev
3 changes: 3 additions & 0 deletions dotnet/samples/04.ai.a.teamsChefBot/env/.env.local
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ TEAMSFX_ENV=local
BOT_ID=
TEAMS_APP_ID=
BOT_DOMAIN=


APP_NAME_SUFFIX=local
2 changes: 1 addition & 1 deletion dotnet/samples/04.ai.a.teamsChefBot/teamsapp.local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: TeamsChef-${{TEAMSFX_ENV}}
name: TeamsChef${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand Down
2 changes: 1 addition & 1 deletion dotnet/samples/04.ai.a.teamsChefBot/teamsapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: TeamsChef-${{TEAMSFX_ENV}}
name: TeamsChef${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": "${{TEAMS_APP_ID}}",
"packageName": "com.package.name",
"name": {
"short": "GPT ME-${{TEAMSFX_ENV}}",
"short": "GPT ME${{APP_NAME_SUFFIX}}",
"full": "GPT Message Extensions"
},
"developer": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ BOT_ID=
TEAMS_APP_ID=
TEAMS_APP_TENANT_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=
BOT_DOMAIN=
BOT_DOMAIN=

APP_NAME_SUFFIX=dev
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ TEAMS_APP_ID=
TEAMS_APP_TENANT_ID=
TEAMSFX_M365_USER_NAME=
BOT_DOMAIN=
BOT_ENDPOINT=
BOT_ENDPOINT=

APP_NAME_SUFFIX=local
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ provision:
# Automates the creation of a Teams app registration and saves the App ID to an environment file.
- uses: teamsApp/create
with:
name: GPT-ME-${{TEAMSFX_ENV}}
name: GPT-ME${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
teamsAppId: TEAMS_APP_ID

# Automates the creation an Azure AD app registration which is required for a bot.
# The Bot ID (AAD app client ID) and Bot Password (AAD app client secret) are saved to an environment file.
- uses: botAadApp/create
with:
name: GPT-ME-${{TEAMSFX_ENV}}
name: GPT-ME${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
botId: BOT_ID
botPassword: SECRET_BOT_PASSWORD
Expand Down
4 changes: 2 additions & 2 deletions dotnet/samples/04.ai.b.messageExtensions.gptME/teamsapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ provision:
# Automates the creation of a Teams app registration and saves the App ID to an environment file.
- uses: teamsApp/create
with:
name: GPT-ME-${{TEAMSFX_ENV}}
name: GPT-ME${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
teamsAppId: TEAMS_APP_ID

# Automates the creation an Azure AD app registration which is required for a bot.
# The Bot ID (AAD app client ID) and Bot Password (AAD app client secret) are saved to an environment file.
- uses: botAadApp/create
with:
name: GPT-ME-${{TEAMSFX_ENV}}
name: GPT-ME${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
botId: BOT_ID
botPassword: SECRET_BOT_PASSWORD
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"outline": "outline.png"
},
"name": {
"short": "LightBot-${{TEAMSFX_ENV}}",
"short": "LightBot${{APP_NAME_SUFFIX}}",
"full": "Light Bot"
},
"description": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ BOT_ID=
TEAMS_APP_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=
BOT_DOMAIN=
TEAMS_APP_TENANT_ID=
TEAMS_APP_TENANT_ID=

APP_NAME_SUFFIX=dev
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: LightBot-${{TEAMSFX_ENV}}
name: LightBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand All @@ -18,7 +18,7 @@ provision:
- uses: botAadApp/create
with:
# The Azure Active Directory application's display name
name: LightBot-${{TEAMSFX_ENV}}
name: LightBot${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
# The Azure Active Directory application's client id created for bot.
botId: BOT_ID
Expand Down
4 changes: 2 additions & 2 deletions dotnet/samples/04.ai.c.actionMapping.lightBot/teamsapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: LightBot-${{TEAMSFX_ENV}}
name: LightBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand All @@ -21,7 +21,7 @@ provision:
- uses: botAadApp/create
with:
# The Azure Active Directory application's display name
name: LightBot-${{TEAMSFX_ENV}}
name: LightBot${{APP_NAME_SUFFIX}}
writeToEnvironmentFile:
# The Azure Active Directory application's client id created for bot.
botId: BOT_ID
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": "${{TEAMS_APP_ID}}",
"packageName": "com.package.name",
"name": {
"short": "ListBot-${{TEAMSFX_ENV}}",
"short": "ListBot${{APP_NAME_SUFFIX}}",
"full": "List Bot"
},
"developer": {
Expand Down
3 changes: 3 additions & 0 deletions dotnet/samples/04.ai.d.chainedActions.listBot/env/.env.dev
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ BOT_ID=
TEAMS_APP_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=
BOT_DOMAIN=


APP_NAME_SUFFIX=dev
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ TEAMSFX_ENV=local
BOT_ID=
TEAMS_APP_ID=
BOT_DOMAIN=


APP_NAME_SUFFIX=local
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: ListBot-${{TEAMSFX_ENV}}
name: ListBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ provision:
- uses: teamsApp/create
with:
# Teams app name
name: ListBot-${{TEAMSFX_ENV}}
name: ListBot${{APP_NAME_SUFFIX}}
# Write the information of created resources into environment file for
# the specified environment variable(s).
writeToEnvironmentFile:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": "${{TEAMS_APP_ID}}",
"packageName": "com.package.name",
"name": {
"short": "DevOps Bot-${{TEAMSFX_ENV}}",
"short": "DevOps Bot${{APP_NAME_SUFFIX}}",
"full": "DevOps Bot"
},
"developer": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ BOT_ID=
TEAMS_APP_ID=
TEAMS_APP_TENANT_ID=
BOT_AZURE_APP_SERVICE_RESOURCE_ID=
BOT_DOMAIN=
BOT_DOMAIN=

APP_NAME_SUFFIX=dev
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ TEAMS_APP_ID=
TEAMS_APP_TENANT_ID=
TEAMSFX_M365_USER_NAME=
BOT_DOMAIN=
BOT_ENDPOINT=
BOT_ENDPOINT=

APP_NAME_SUFFIX=local
Loading
Loading