Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] bump: Migrate to OpenAI's official .NET SDK #1858

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Conversation

singhk97
Copy link
Collaborator

@singhk97 singhk97 commented Jul 18, 2024

Linked issues

closes: #1821 (issue number)

Details

  • Migrated from Azure.AI.OpenAI to openai's official .NET sdk OpenAI.

Change details

  • [BREAKING] Removed /completions completions endpoint support for both OpenAI & AzureOpenAI. It was deprecated by OpenAI June 2023 and virtually no one uses it.
    • Updated all the samples to migrate to /chat endpoint.
  • Updated default AzureOpenAI api version to 2024-06-01.
    • The earliest supported api version is now 2024-04-01-preview. This is a consequence of using the openai's dotnet sdk OpenAI.
  • Migrated OpenAIModel & OpenAIEmbeddings class' underlying clients.

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@singhk97 singhk97 changed the title [C#] feat: Bump Azure.AI.OpenAI to v2 beta and migrate core client sdk to openai's official .NET sdk. [C#] feat: Migrate to OpenAI's official .NET SDK Jul 18, 2024
@singhk97 singhk97 changed the title [C#] feat: Migrate to OpenAI's official .NET SDK [C#] bump: Migrate to OpenAI's official .NET SDK Jul 18, 2024
@singhk97 singhk97 changed the title [C#] bump: Migrate to OpenAI's official .NET SDK [C#] bump: Migrate to OpenAI's official .NET SDK Jul 18, 2024
@singhk97 singhk97 marked this pull request as ready for review July 18, 2024 23:11
@singhk97 singhk97 merged commit 2d49a75 into main Jul 25, 2024
11 checks passed
@singhk97 singhk97 deleted the migrate-aoai-client branch July 25, 2024 17:36
@singhk97 singhk97 mentioned this pull request Aug 5, 2024
1 task
singhk97 added a commit that referenced this pull request Aug 5, 2024
## Linked issues

closes: #minor (issue number)

## Details
Changes: 
* #1820
*  #1858 
* #1869 
* #1887 
* Bump samples to use v1.5.0

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Migrate from Azure.AI.OpenAI to OpenAI package
2 participants