Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY] feat: deploy Python echo bot to azure #1353

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

blackchoey
Copy link
Contributor

Linked issues

closes: #1254

Details

  1. Update configuration to make echo bot work after deploy to Azure
  2. Use Teams-AI rc release
  3. Add Teams Toolkit .env files, for users to better understand what information will be generated by Toolkit
  4. Change Teams Toolkit configuration version to latest
  5. Use debugpy task per Python extension's latest change

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@aacebo aacebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poetry.lock should be checked in to source control

@blackchoey
Copy link
Contributor Author

poetry.lock should be checked in to source control

@aacebo My understanding is poetry.lock is similar to package.lock.json in nodejs. For sample projects, we can remove it from source control so users can always get latest packages that satisfies the dependency in pyproject.toml. The benefit to us is we don't need to maintain (update) the lock file to use latest packages to avoid security vulnerabilities. The JS samples in our repo also does not contain package.lock.json.

Please let me know how you think. I will add poetry.lock if that's what we want to do.

@aacebo aacebo merged commit 490d341 into main Feb 29, 2024
22 checks passed
@aacebo aacebo deleted the chyuan/echo-bot-azure branch February 29, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PY] Update EchoBot
2 participants