Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] chore: Unit tests #1288

Merged
merged 11 commits into from
Feb 22, 2024
Merged

[JS] chore: Unit tests #1288

merged 11 commits into from
Feb 22, 2024

Conversation

corinagum
Copy link
Collaborator

@corinagum corinagum commented Feb 15, 2024

Linked issues

closes: #54

Details

Provide a list of your changes here. If you are fixing a bug, please provide steps to reproduce the bug.

Change details

  • Add unit tests
  • Ignore unit tests coverage for Colorize.spec.ts -- the tests don't pass on pipeline run so we don't want to include it in test coverage
  • Fix TestAdapter tests
  • Add express as dev dependency
  • remove eslint security plugin

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@corinagum corinagum merged commit 5e693b0 into main Feb 22, 2024
14 checks passed
@corinagum corinagum deleted the cg/ut-6 branch February 22, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JS] Unit tests
3 participants