Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] feat: Add enableSso property to toggle SSO in user auth scenarios #1236

Merged
merged 13 commits into from
Feb 7, 2024

Conversation

singhk97
Copy link
Collaborator

@singhk97 singhk97 commented Feb 3, 2024

Linked issues

closes: #1194 #991

Details

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

aacebo
aacebo previously approved these changes Feb 5, 2024
Copy link
Collaborator

@aacebo aacebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment nit, other than that looks good.

@singhk97 singhk97 merged commit 09ebba1 into main Feb 7, 2024
15 checks passed
@singhk97 singhk97 deleted the kavin/enable-sso branch February 7, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add the ability to enable or disable SSO in User Authentication
3 participants