Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] fix: fix type of image message #1124

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

kuojianlu
Copy link
Contributor

@kuojianlu kuojianlu commented Jan 4, 2024

Linked issues

closes: #1113

Details

Provide a list of your changes here. If you are fixing a bug, please provide steps to reproduce the bug.

Change details

Describe your changes, with screenshots and code snippets as appropriate

code snippets:

screenshots:

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@kuojianlu kuojianlu changed the title [JS] fix type of image message [JS] fix: fix type of image message Jan 4, 2024
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is correct. The code is showing data:base64 as expected input. Is there some other indicator that it must be a url?

@corinagum corinagum merged commit c5f7dc0 into main Jan 5, 2024
14 of 15 checks passed
@corinagum corinagum deleted the kuojianlu/fix-image-type branch January 5, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: the type of image message should be image_url rather than image
2 participants