Skip to content

Fix Login.EnumDatabaseMappings query to avoid double evaluation of suser_sname #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −15
Draft

Fix Login.EnumDatabaseMappings query to avoid double evaluation of suser_sname #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d01e918
Initial plan
Copilot Oct 10, 2025
9141eb4
Fix Login.EnumDatabaseMappings to return empty array instead of null
Copilot Oct 10, 2025
2fbadbf
Fix DatabaseMappings query to avoid double evaluation of suser_sname
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions src/Microsoft/SqlServer/Management/Smo/LoginBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1424,7 +1424,7 @@ public DatabaseMapping[] EnumDatabaseMappings()
{
CheckObjectState();

DatabaseMapping[] mapping = null;
DatabaseMapping[] mapping = new DatabaseMapping[0];
if (!this.IsDesignMode)
{
Urn uMappings = this.Urn.ToString() + "/DatabaseMapping";
Expand All @@ -1434,18 +1434,13 @@ public DatabaseMapping[] EnumDatabaseMappings()
if (dt.Rows.Count > 0)
{
mapping = new DatabaseMapping[dt.Rows.Count];
}
else
{
return null;
}

for (int iRow = 0; iRow < dt.Rows.Count; iRow++)
{
DataRow dr = dt.Rows[iRow];
mapping[iRow] = new DatabaseMapping(Convert.ToString(dr["LoginName"], SmoApplication.DefaultCulture),
Convert.ToString(dr["DBName"], SmoApplication.DefaultCulture),
Convert.ToString(dr["UserName"], SmoApplication.DefaultCulture));
for (int iRow = 0; iRow < dt.Rows.Count; iRow++)
{
DataRow dr = dt.Rows[iRow];
mapping[iRow] = new DatabaseMapping(Convert.ToString(dr["LoginName"], SmoApplication.DefaultCulture),
Convert.ToString(dr["DBName"], SmoApplication.DefaultCulture),
Convert.ToString(dr["UserName"], SmoApplication.DefaultCulture));
}
}
}
else
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft/SqlServer/Management/SqlEnum/xml/DatabaseMappings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ begin
</prefix>
<version min_major = '7' max_major = '8'>
<prefix>
exec('use ' + @db_name + ' INSERT #loginmappings select suser_sname(u.sid), db_name(), u.name, null from dbo.sysusers u where suser_sname(u.sid) is not null')
exec('use ' + @db_name + ' INSERT #loginmappings select login_name, db_name(), u.name, null from dbo.sysusers u CROSS APPLY (SELECT suser_sname(u.sid) AS login_name) AS ln where ln.login_name is not null')
</prefix>
</version>
<version min_major = '9' >
<prefix>
exec('use ' + @db_name + ' INSERT #loginmappings select suser_sname(u.sid), db_name(), u.name, null from sys.database_principals AS u where suser_sname(u.sid) is not null')
exec('use ' + @db_name + ' INSERT #loginmappings select login_name, db_name(), u.name, null from sys.database_principals AS u CROSS APPLY (SELECT suser_sname(u.sid) AS login_name) AS ln where ln.login_name is not null')
</prefix>
</version>
<prefix>
Expand Down