Sync to 172.52.0

CHANGELOG.md

@@ -3,6 +3,19 @@
 Update this document for externally visible changes. Put most recent changes first.
 Once we push a new version to nuget.org add a double hash header for that version.
 
+## 172.52.0
+
+- Add 170 compat support
+- Update NetFx binaries to net472
+- Remove obsolete formatter-based serialization constructors from non-Netfx Exceptions
+- Added new `DateLastModified` property on Error Logs returned by `EnumErrorLogs()`. Its value is the same as the existing `CreateDate`,
+  (which has been incorrectly namd for years) only properly stampted with the date/time offset information to allow easier 
+  interoperability between client and servers in different time zones. `CreateDate` is essentially deprecated, and new applications
+  should start using `DateLastModified` instead.
+- Fixed an issue in the `EnumErrorLogs()` where `CreateDate` field could be `NULL` depending on the configuration of the machine 
+  on which SQL Server was running on.
+- Regex for the EXECUTE statement was updated to also match the shortened form 'EXEC'
+
 ## 171.30.0
 
 - <b>BREAKING</b>: Move Transfer interfaces to Smo.Extended and remove unused/non-implemented interfaces. This is a breaking change that requires recompilation of apps that use Transfer.

Directory.Build.props

@@ -1,8 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!--
-  This root MSBuild file is automatically imported for all projects in the tree by MSBuild 15.0 and serves as the central entry point for CBT.
-  You can have a hierarchy of imports but make sure that this file is still imported.
--->
 <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup Label="Global locations">
     <!--
@@ -15,8 +11,6 @@
       Enlistment root is based off of wherever this file is.  Be sure not to set this property anywhere else.
     -->
     <EnlistmentRoot>$(MSBuildThisFileDirectory.TrimEnd('\\'))</EnlistmentRoot>
-    <NetfxVersion>net462</NetfxVersion>
+    <NetfxVersion>net472</NetfxVersion>
   </PropertyGroup>
-
-
 </Project>

Packages.props

@@ -13,38 +13,48 @@
       <DotNetPackagesVersion>6.0.0</DotNetPackagesVersion>
     </PropertyGroup>
     <ItemGroup>
-        <PackageReference Update="Azure.Core" Version="1.35.0" />
-        <PackageReference Update="Azure.Identity" Version="1.10.3" />
+        <!--
+        When adding new package dependencies here, make sure to also add those packages to
+        Microsoft.SqlServer.Smo.TestUtils.nuspec if they affect any of the related test utilities.
+        -->
+        <PackageReference Update="Azure.Core" Version="1.41.0" />
+        <PackageReference Update="Azure.Identity" Version="1.11.4" />
+        <PackageReference Update="Azure.ResourceManager" Version="1.8.0" />
+        <PackageReference Update="Azure.ResourceManager.Storage" Version="1.1.1" />
         <PackageReference Update="Azure.Security.KeyVault.Secrets" Version="4.4.0" />
+        <PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
         <PackageReference Update="Microsoft.Data.SqlClient" Version="[$(SqlClientPackageVersion),6)" />
         <PackageReference Update="Microsoft.Data.Tools.StringResourceTool" Version="3.2.0" />
-        <PackageReference Update="Microsoft.Identity.Client"                                Version="4.56.0" />
-        <PackageReference Update="Microsoft.Identity.Client.Desktop"                        Version="4.56.0" />
+        <PackageReference Update="Microsoft.Identity.Client" Version="4.61.3" />
+        <PackageReference Update="Microsoft.Identity.Client.Desktop" Version="4.61.3" />
         <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.3.0" />
+        <PackageReference Update="Microsoft.SqlServer.ADO.Identity" Version="171.38.0" />
         <PackageReference Update="Microsoft.SqlServer.Assessment" Version="1.1.9" />
         <PackageReference Update="Microsoft.SqlServer.Management.SqlParser" Version="$(SqlParserPackageVersion)" />
         <PackageReference Update="Moq" Version="4.16.1" />
         <PackageReference Update="MSTest.TestAdapter" Version="2.2.10" />
         <PackageReference Update="MSTest.TestFramework" Version="2.2.10" />
         <PackageReference Update="NewtonSoft.Json" Version="13.0.1" />
         <PackageReference Update="NUnit" Version="3.11.0" />
-        <PackageReference Update="System.Buffers"                                           Version="4.5.1" />
+        <PackageReference Update="System.Buffers" Version="4.5.1" />
+        <PackageReference Update="System.CommandLine" Version="2.0.0-beta4.22272.1" />
         <PackageReference Update="System.Data.OleDb" Version="$(DotNetPackagesVersion)" />
-        <PackageReference Update="System.Diagnostics.DiagnosticSource"                      Version="6.0.1" />
+        <PackageReference Update="System.Diagnostics.DiagnosticSource" Version="6.0.1" />
         <PackageReference Update="System.Management" Version="$(DotNetPackagesVersion)" />
-        <PackageReference Update="System.Memory"                                            Version="4.5.5"/>
-        <PackageReference Update="System.Runtime.CompilerServices.Unsafe"                   Version="$(DotNetPackagesVersion)" />
+        <PackageReference Update="System.Memory" Version="4.5.5" />
+        <PackageReference Update="System.Runtime.CompilerServices.Unsafe" Version="$(DotNetPackagesVersion)" />
         <PackageReference Update="System.Security.Cryptography.ProtectedData" Version="$(DotNetPackagesVersion)" />
         <PackageReference Update="System.Security.Permissions" Version="$(DotNetPackagesVersion)" />
         <PackageReference Update="System.Security.Principal.Windows" Version="5.0.0" />
+        <PackageReference Update="System.Text.Encodings.Web" Version="8.0.0" />
+        <PackageReference Update="System.Text.Json" Version="8.0.4" />
         <PackageReference Update="System.Threading.Tasks.Extensions" Version="4.5.4" />
         <PackageReference Update="System.ValueTuple" Version="4.5.0" />
     </ItemGroup>
     <ItemGroup>
         <!-- GlobalPackageReference packages are installed and processed by msbuild but are not referenced by the C# compiler -->
-        <GlobalPackageReference Include="StrawberryPerl" Version="5.28.0.1" GeneratePathProperty="true" />
+        <GlobalPackageReference Condition="!Exists('c:\strawberry\perl\bin\perl.exe')" Include="StrawberryPerl" Version="5.28.0.1" GeneratePathProperty="true" />
         <GlobalPackageReference Include="Microsoft.TestPlatform" Version="17.6.0" GeneratePathProperty="true" />
-
     </ItemGroup>
 
 </Project>

README.md

@@ -12,28 +12,18 @@ SMO packages on nuget.org include:
 
 ### Microsoft.SqlServer.SqlManagementObjects
 
-This package is the primary development SDK for SMO. It provides both NetFx and NetStandard binaries. Capabilities of the NetStandard binaries may be limited by that platform, such as the lack of WMI support.
-Version suffixes for this package include "preview" and "msdata". The preview suffix indicates the package was built using System.Data and System.Data.SqlClient as its SQL client driver for NetFx.
-The msdata suffix indicate the package uses Microsoft.Data.SqlClient as its SQL client driver for NetFx.
+This package is the primary development SDK for SMO. It provides both NetFx and .Net binaries. Capabilities of the NetStandard binaries may be limited by that platform, such as the lack of WMI support.
+
 The binaries are strong named and Authenticode signed.
 
 ### Microsoft.SqlServer.SqlManagementObjects.Loc
 
 This package has resource DLLs with localized strings corresponding to the DLLs in Microsoft.SqlServer.SqlManagementObjects.
 
-### Microsoft.SqlServer.SqlManagementObjects.SSMS
-
-This package has NetFx binaries that continue to use System.Data.SqlClient as their SQL client driver.
-It is mainly intended for use by Sql Server Management Studio and Sql Server Data Tools until such time as those tools can upgrade to Microsoft.Data.SqlClient.
-If you are building SSMS 18 extensions that depend on SMO, use this package instead of Microsoft.SqlServer.SqlManagementObjects.
-
 ## Microsoft.SqlServer.Management.SmoMetadataProvider
 
 SmoMetadataProvider provides completion support for TSQL language services in Azure Data Studio and the Sql Server extension for VS Code.
 
-## Microsoft.SqlServer.Management.SmoMetadataProvider.SSMS
-
-SmoMetadataProvider.SSMS provides completion support for the TSQL language service in Sql Server Management Studio.
 
 ## Versioning
 

SmoBuild/DdlEvents.targets

@@ -7,7 +7,8 @@
     <DdlEventsGenCompile Include="$(BuildPropsDir)\DdlEvents\*" />
   </ItemGroup>
   <PropertyGroup>
-      <Perl>$(PkgStrawberryPerl)\bin\perl.exe</Perl>
+      <Perl Condition="Exists('c:\strawberry\perl\bin\perl.exe')">c:\strawberry\perl\bin\perl.exe</Perl>
+      <Perl Condition="'$(Perl)' == ''">$(PkgStrawberryPerl)\bin\perl.exe</Perl>
     </PropertyGroup>
   <ItemDefinitionGroup>
     <!-- the defaults are for sqlenum -->
@@ -25,10 +26,10 @@
     BeforeTargets="ResolveReferences" 
     Inputs="$(MSBuildThisFileFullPath);@(DdlEventsGenCompile)" 
     Outputs="@(EventsFileName->'$(SmoCodeGenOutputDir)\%(CodeFile).cs')" >
-    <Message Importance="high" Text="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\trc2evt.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\trccomn.h&quot; &quot;$(BuildPropsDir)\DdlEvents\trcdef.cpp&quot; &quot;$(SmoCodeGenOutputDir)&quot; 0 %(EventsFileName.EventTraceBuildType)" />
-    <Exec Command="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\trc2evt.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\trccomn.h&quot; &quot;$(BuildPropsDir)\DdlEvents\trcdef.cpp&quot; &quot;$(SmoCodeGenOutputDir)&quot; 0 %(EventsFileName.EventTraceBuildType)" />
-    <Message Importance="high" Text="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\evtschema.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\eventsdef.cpp&quot; &quot;$(SmoCodeGenOutputDir)&quot;" />
-    <Exec Command="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\evtschema.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\eventsdef.cpp&quot; &quot;$(SmoCodeGenOutputDir)&quot;" />
+    <Message Importance="high" Text="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\trc2evt.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\trccomn.txt&quot; &quot;$(BuildPropsDir)\DdlEvents\trcdef.txt&quot; &quot;$(SmoCodeGenOutputDir)&quot; 0 %(EventsFileName.EventTraceBuildType)" />
+    <Exec Command="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\trc2evt.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\trccomn.txt&quot; &quot;$(BuildPropsDir)\DdlEvents\trcdef.txt&quot; &quot;$(SmoCodeGenOutputDir)&quot; 0 %(EventsFileName.EventTraceBuildType)" />
+    <Message Importance="high" Text="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\evtschema.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\eventsdef.txt&quot; &quot;$(SmoCodeGenOutputDir)&quot;" />
+    <Exec Command="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\evtschema.pl&quot; &quot;$(BuildPropsDir)\DdlEvents\eventsdef.txt&quot; &quot;$(SmoCodeGenOutputDir)&quot;" />
     <Message Importance="high" Text="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\smoevt.pl&quot; %(EventsFileName.GenType) &quot;$(SmoCodeGenOutputDir)\eventsschema.tmp&quot; &quot;$(BuildPropsDir)\DdlEvents\%(EventsFileName.ClassEnumTemplate).cs&quot; &quot;$(BuildPropsDir)\DdlEvents\%(EventsFileName.EventEnumTemplate).cs&quot; &quot;$(SmoCodeGenOutputDir)\smoevt_gen_template.cs&quot; &gt; &quot;$(SmoCodeGenOutputDir)\%(EventsFileName.CodeFile).cs&quot;" />
     <Exec Command="$(Perl) &quot;$(BuildPropsDir)\DdlEvents\smoevt.pl&quot; %(EventsFileName.GenType) &quot;$(SmoCodeGenOutputDir)\eventsschema.tmp&quot; &quot;$(BuildPropsDir)\DdlEvents\%(EventsFileName.ClassEnumTemplate).cs&quot; &quot;$(BuildPropsDir)\DdlEvents\%(EventsFileName.EventEnumTemplate).cs&quot; &quot;$(SmoCodeGenOutputDir)\smoevt_gen_template.cs&quot; &gt; &quot;$(SmoCodeGenOutputDir)\%(EventsFileName.CodeFile).cs&quot;" />
     <ItemGroup>