.Net: Sanitize function names #10257
Merged
+128
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
SergeyMenshykh
added
ai connector
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
markwallace-microsoft
added
the
kernel
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
commented
Jan 22, 2025
dotnet/src/Connectors/Connectors.OpenAI/Core/ClientCore.ChatCompletion.cs
Show resolved
Hide resolved
westey-m
reviewed
Jan 22, 2025
dotnet/src/Connectors/Connectors.OpenAI/Core/ClientCore.ChatCompletion.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
Jan 22, 2025
…nshykh/semantic-kernel into sanitize-function-names
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Jan 22, 2025
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, if an AI model hallucinates a function name (e.g.,
bar.fooinstead of the advertisedbar-foo) that contains disallowed characters (not in the range ofa-zA-Z0-9_-), SK identifies it as an error case and sends the error back to the model along with the original function call. Given that the original function call contains the disallowed function name, the request to the AI model fails with the error: Invalid 'messages[6].tool_calls[0].function.name': string does not match pattern. Expected a string that matches the pattern^[a-zA-Z0-9_-]+$.Description
This PR replaces disallowed characters in function names with an underscore for all function calls before sending them to the AI model. This fix prevents the request to the AI model from failing and allows the model to auto-recover.
More context: Function Calling Reliability ADR
Closes: #9850