-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add agent invocation spans #10255
Merged
moonbox3
merged 4 commits into
microsoft:main
from
TaoChenOSU:taochen/python-agent-diagnostics
Jan 22, 2025
Merged
Python: Add agent invocation spans #10255
moonbox3
merged 4 commits into
microsoft:main
from
TaoChenOSU:taochen/python-agent-diagnostics
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Add agent invocation spans
Python: Add agent invocation spans
Jan 22, 2025
moonbox3
approved these changes
Jan 22, 2025
esttenorio
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a readme or a demo mentioning/explaining the use of the new decorator?
moonbox3
reviewed
Jan 22, 2025
python/tests/unit/utils/agent_diagnostics/test_trace_open_ai_assistant_agent.py
Outdated
Show resolved
Hide resolved
moonbox3
approved these changes
Jan 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Address feature request: #10174
Description
This pull request introduces a new decorator for tracing agent invocations and applies it to various methods in the
ChatCompletionAgent
andOpenAIAssistantAgent
classes. Additionally, it includes new unit tests to ensure the decorator is correctly applied and functions as expected.Key Changes:
Decorator Implementation:
trace_agent_invocation
decorator inpython/semantic_kernel/utils/telemetry/agent_diagnostics/decorators.py
to trace agent invocations using OpenTelemetry.Decorator Application:
trace_agent_invocation
decorator to theinvoke
andinvoke_stream
methods inChatCompletionAgent
(python/semantic_kernel/agents/chat_completion/chat_completion_agent.py
). [1] [2] [3]trace_agent_invocation
decorator to theinvoke
andinvoke_stream
methods inOpenAIAssistantAgent
(python/semantic_kernel/agents/open_ai/open_ai_assistant_base.py
). [1] [2] [3]Contribution Checklist