Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Grab function_name from kwargs if present in ProcessStepEdgeBuilder #10245

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

In the ProcessStepEdgeBuilder, we allow one to pass in a target of type "ProcessFunctionTargetBuilder | ProcessStepBuilder". If the target isinstance(target, ProcessStepBuilder), we construct the ProcessFunctionTargetBuilder. We weren't grabbing the function_name from the kwargs if it was presented, resulting in an exception that the function_name needs to be provided because multiple kernel functions exist.

Description

This PR:

  • correctly passes in the function_name kwargs, if present.
  • Adds a unit test to exercise functionality

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner January 21, 2025 02:49
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jan 21, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 21, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/processes
   process_step_edge_builder.py35391%43, 60, 70
TOTAL16709177889% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3002 4 💤 0 ❌ 0 🔥 1m 15s ⏱️

@TaoChenOSU TaoChenOSU added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@moonbox3 moonbox3 enabled auto-merge January 21, 2025 22:44
@moonbox3 moonbox3 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into microsoft:main with commit 3a7f2a3 Jan 21, 2025
25 checks passed
@moonbox3 moonbox3 deleted the py-process-func-name-fix branch January 21, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants