[api-extractor] Fix a bug where an item is exported from both the entry point and an exported AstNamespaceImport.

[zelliott]

Summary

This PR fixes a minor bug introduced in #3552.

Details

Suppose you have the following setup:

// index.ts
import {Foo} from './internal';
import * as internal from './internal';

export {Foo, internal}

// internal.ts
export class Foo {}

In the code above, Foo is consumable both from the entry point and from a consumable AstNamespaceImport.

Before #3552

Foo is written twice to the doc model: once under the ApiEntryPoint, once under the ApiNamespace internal. This is probably not the ideal behavior, but it's what users before #3552 expect.

After #3552

When docModel.includeForgottenExports is disabled, Foo is now only written once to the doc model under the ApiNamespace. This is due to some incorrect code within ApiModelGenerator.ts that does not process an entry point entity if the entity has any parent entities. This code is incorrect because I didn't consider entities that are exported both from the entry point and from an AstNamespaceImport. Instead, this logic should only process entities that are exported from the entry point. This PR implements that fix.

Additionally, I fixed a bug that occurs in this scenario when docModel.includeForgottenExports is enabled.

Previously, ApiModelGenerator.ts determined whether an item is exported based upon whether it was exported from any parent module (via CollectorEntity.exported). However, this doesn't work if an item is written multiple times to the doc model. This doesn't work because the item's "exported-ness" needs to be evaluated with respect to its respective ApiItemContainerMixin.

Thus. I updated ApiModelGenerator.ts to pass isExported through the process functions. In doing this, I modified the method signatures of the process functions to be more readable by introducing a context parameter and interface. (because we were passing four arguments into each method).

How it was tested

I added two api-extractor-scenario tests: namespaceImports and namespaceImports2:

• namespaceImports: A scenario where a class is exported from two AstNamespaceImport namespaces, and both namespaces are exported from the entry point.
• namespaceImports2: A scenario where a class is exported from both an AstNamespaceImport and the entry point.

These test scenarios are also added in #3602 to validate some declaration reference construction logic. This will make rebasing/coordinating between the two PRs easier.

[zelliott]

This addition is expected. ForgottenExport6 is exported from an un-exported AstNamespaceImport. It will appear twice in the doc model:

• Once under the un-exported namespace internal2, with the reference api-extractor-scenarios!~internal2.ForgottenExport6:class.
• Once under the entry point itself, with the reference api-extractor-scenarios!~ForgottenExport6:class.

It appears twice because today for largely the same reason items exported from both the entry point and an exported AstNamespaceImport appear twice today. We can improve this behavior in a follow-up PR.

[octogonz]

@zelliott I updated this change message. Our change log guidelines recommend to use the word "issue" or "regression" instead of "bug".

[octogonz]

🚀 Released with @microsoft/[email protected]

Thanks for your patience!