[api-documenter] Adjusting package name parser in OfficeYamlDocumenter #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJerabek
requested review from
apostolisms,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
octogonz
approved these changes
Sep 11, 2019
rikhoffbauer
pushed a commit
to rikhoffbauer/microsoft__api-documenter
that referenced
this pull request
Mar 23, 2020
[api-documenter] Adjusting package name parser in OfficeYamlDocumenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1337 changed the format of UIDs. We currently parse out the package name in the OfficeYamlDocumenter. The syntax changed from
excel.Excel.footoexcel!Excel.foo, so the regex needs to changed accordingly.