feat(windows): Create standalone daemon for non-k8s orchestration #1385
+1,501
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeegiiK
changed the title
There was a problem hiding this comment.
PR Overview
This PR introduces a standalone daemon for non-K8s orchestration. Key changes include:
- Adding a standalone cache implementation with its corresponding test.
- Implementing a new standalone daemon in the cmd package.
- Introducing a BootstrapManager to initialize and start the daemon in non-Kubernetes environments.
Reviewed Changes
| File | Description |
|---|---|
| pkg/controllers/cache/standalone_cache_test.go | Adds tests for standalone cache functionality |
| cmd/standalone_daemon.go | Implements a new standalone daemon for Retina orchestration |
| cmd/bootstrap_manager.go | Introduces a bootstrap manager to bootstrap the daemon |
| pkg/controllers/cache/standalone_cache.go | Implements cache logic used by the standalone daemon |
| cmd/standard/daemon.go | Updates daemon configuration and startup to integrate new behavior |
| cmd/root.go | Updates CLI to use the new BootstrapManager instead of the daemon directly |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
cmd/bootstrap_manager.go:43
- [nitpick] Consider using the logger for output instead of fmt.Printf to maintain consistent logging and potentially capture log levels and context.
fmt.Printf("Bootstrapping Retina")
cmd/standalone_daemon.go
Outdated
Comment on lines
49
to
86
| cache := cache.NewStandaloneCache() | ||
| enrich := enricher.NewStandaloneEnricher(ctx, cache) | ||
| enrich.Run() | ||
|
|
||
| sd.pluginManager, err = pm.NewPluginManager( | ||
| sd.config, | ||
| tel, | ||
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create plugin manager: %w", err) | ||
| } | ||
|
|
||
| sd.httpServer = sm.NewHTTPServer( | ||
| sd.config.APIServer.Host, | ||
| sd.config.APIServer.Port, | ||
| ) | ||
|
|
||
| if err := sd.httpServer.Init(); err != nil { | ||
| mainLogger.Fatal("Failed to start http server", zap.Error(err)) | ||
| } | ||
| defer sd.pluginManager.Stop() | ||
|
|
||
| // start heartbeat goroutine for application insights | ||
| go tel.Heartbeat(ctx, sd.config.TelemetryInterval) | ||
|
|
||
| var g *errgroup.Group | ||
| g, ctx = errgroup.WithContext(ctx) | ||
|
|
||
| g.Go(func() error { | ||
| return sd.pluginManager.Start(ctx) | ||
| }) | ||
| g.Go(func() error { | ||
| return sd.httpServer.Start(ctx) | ||
| }) | ||
|
|
||
| if err := g.Wait(); err != nil { | ||
| mainLogger.Panic("Error running standalone daemon", zap.Error(err)) | ||
| } |
There was a problem hiding this comment.
This looks like duplication of Controller Manager. Can't CM be reused in standalone daemon? (If not directly now, can it be refactored to fit both daemons?)
Comment on lines
37
to
84
| func TestAddPod(t *testing.T) { | ||
| if _, err := log.SetupZapLogger(log.GetDefaultLogOpts()); err != nil { | ||
| t.Fatalf("Failed to setup logger: %v", err) | ||
| } | ||
| cache := NewStandaloneCache() | ||
|
|
||
| emptyPodInfo := cache.GetPod(ip) | ||
| if emptyPodInfo != nil { | ||
| t.Fatalf("Expected nil, got %v", emptyPodInfo) | ||
| } | ||
|
|
||
| cache.ProcessPodInfo(ip, defaultInfo) | ||
| podInfo := cache.GetPod(ip) | ||
|
|
||
| if podInfo == nil { | ||
| t.Fatalf("Expected pod info, got nil") | ||
| } | ||
| assert.Equal(t, podInfo.Name, name) | ||
| assert.Equal(t, podInfo.Namespace, namespace) | ||
| } | ||
|
|
||
| func TestDeletePod(t *testing.T) { | ||
| if _, err := log.SetupZapLogger(log.GetDefaultLogOpts()); err != nil { | ||
| t.Fatalf("Failed to setup logger: %v", err) | ||
| } | ||
| cache := NewStandaloneCache() | ||
|
|
||
| // Add pod | ||
| cache.ProcessPodInfo(ip, defaultInfo) | ||
| podInfo := cache.GetPod(ip) | ||
| if podInfo == nil { | ||
| t.Fatalf("Expected pod info, got nil") | ||
| } | ||
|
|
||
| // Attempt to delete pod not in cache | ||
| cache.ProcessPodInfo("9.9.9.9", nil) | ||
| podInfo1 := cache.GetPod(ip) | ||
| if podInfo1 == nil { | ||
| t.Fatalf("Expected pod info, got nil") | ||
| } | ||
|
|
||
| // Delete pod | ||
| cache.ProcessPodInfo(ip, nil) | ||
| deletedPodInfo := cache.GetPod(ip) | ||
| if deletedPodInfo != nil { | ||
| t.Fatalf("Expected nil, got %v", deletedPodInfo) | ||
| } | ||
| } |
There was a problem hiding this comment.
these tests seems to be testing ProcessPodInfo. Consider adding to a single function TestProcessPodInfo and use table driven tests to test several behaviors of the method (https://dave.cheney.net/2019/05/07/prefer-table-driven-tests)
| defer enricher.Stop() | ||
|
|
||
| err1 := enricher.PublishEvent(ip) | ||
| err2 := enricher.PublishEvent(invalidIP) |
There was a problem hiding this comment.
this is confusing. Are you testing what happens when you try to publish an invalid IP, or you want to check the behavior of a valid IP when channel is full?
There was a problem hiding this comment.
The naming of the variable is misleading. I'm trying to test how the enricher reacts when the channel is full. I'll update the tests soon using the table tests approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.