Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mc): Add module for Prometheus, refactor, add tests #1294

Merged
merged 3 commits into from
Jan 31, 2025
Merged

test(mc): Add module for Prometheus, refactor, add tests #1294

merged 3 commits into from
Jan 31, 2025

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Jan 31, 2025

Description

  • add module for Prometheus deployment
  • add example and test for Prometheus module
  • add tests for each testUtils.go functions
  • refactor

Related Issue

#1267

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SRodi SRodi requested a review from a team as a code owner January 31, 2025 11:28
ritwikranjan
ritwikranjan reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@ritwikranjan ritwikranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly looked at the go part of code.

test/multicloud/test/integration_prometheus_kind_test.go Outdated Show resolved Hide resolved
test/multicloud/test/testTypes.go Outdated Show resolved Hide resolved
test/multicloud/test/testUtils.go Show resolved Hide resolved
test/multicloud/test/testUtils.go Outdated Show resolved Hide resolved
alexcastilio
alexcastilio requested changes Jan 31, 2025
View reviewed changes
test/multicloud/test/testUtils.go Outdated Show resolved Hide resolved
test/multicloud/test/testTypes.go Outdated Show resolved Hide resolved
test/multicloud/test/testUtils_test.go Outdated Show resolved Hide resolved
test/multicloud/test/testUtils.go Outdated Show resolved Hide resolved
test/multicloud/test/testUtils_test.go Outdated Show resolved Hide resolved
test/multicloud/test/testTypes.go Outdated Show resolved Hide resolved
@SRodi SRodi added this pull request to the merge queue Jan 31, 2025
Merged via the queue into microsoft:main with commit e2e7623 Jan 31, 2025
29 checks passed
@SRodi SRodi deleted the test/mc-prometheus branch January 31, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcastilio alexcastilio alexcastilio approved these changes

@csfmomo csfmomo Awaiting requested review from csfmomo csfmomo is a code owner automatically assigned from microsoft/retina

@aranta-rokade aranta-rokade Awaiting requested review from aranta-rokade aranta-rokade is a code owner automatically assigned from microsoft/retina

@ritwikranjan ritwikranjan Awaiting requested review from ritwikranjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SRodi @alexcastilio @ritwikranjan