Fix NuGet lock files and enforce them not changing accidentally #14611
+4,309
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
changed the title
jonthysell
changed the title
jonthysell
added
Area: Compliance
Workstream: ES Compliance SFI
jonthysell
force-pushed
the
packagelockfiles
branch
2 times, most recently
from
3abbc69 to
2b40240
Compare
## Description This PR fixes NuGet lock files so they're more correct/compliant. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why We recently updated to WinAppSDK 1.7 and have made other changes to the flavors we build (with different dependencies) so our lock files were out of date / constantly overriding one another. ### What This PR fixes NuGet lock files so they're more correct/compliant. This includes: 1. Updating the `NuGetRestoreForceEvaluateAllSolutions.ps1` script to completely fix the lock files 2. Ensuring every project has a proper `packages.lock.json` file for its default configuration 3. Ensuring projects that are built old AND new arch also have a separate `newarch` lock file 4. Ensuring projects that are build with/without experimental WinUI3 also have a separate `experimentalwinui3` lock file 5. Causing an (optional) CI build error if the lock files change during the build (they shouldn't) with message to re-run the script 6. Removed all unnecessary `packages.config` files which confuse NuGet restoration ## Screenshots N/A ## Testing Verified no complaints about changed lock files after builds in the pipeline. ## Changelog Should this change be included in the release notes: _no_ # This is the commit message #2: Fix integration-test # This is the commit message #3: fix integration test
jonthysell
force-pushed
the
packagelockfiles
branch
from
2b40240 to
8b1300d
Compare
Yajur-Grover
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes NuGet lock files so they're more correct/compliant, and makes it easier to keep them that way.
Type of Change
Why
We recently updated to WinAppSDK 1.7 and have made other changes to the flavors we build (with different dependencies) so our lock files were out of date / constantly overriding one another.
What
This PR fixes NuGet lock files so they're more correct/compliant. This includes:
NuGetRestoreForceEvaluateAllSolutions.ps1script to completely fix the lock filespackages.lock.jsonfile for its default configurationnewarchlock fileexperimentalwinui3lock filepackages.configfiles which confuse NuGet restorationScreenshots
N/A
Testing
Verified no complaints about changed lock files after builds in the pipeline.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow