Implement OnScrollEndDrag Event Handler for ScrollView #14473

sharath2727 · 2025-04-02T14:53:27Z

Description

Type of Change

Enhancement (non-breaking change)

Why

Implement OnScrollEndDrag Event Handler for fabric implementation of ScrollView.

Resolves #13143

What

Added FireScrollEndDrag handler to be fired when the InteractionTracker state is entering inertia - InertiaStateEntered
Adjusted FireScrollBeginDrag to be fired when the InteractionTracker state is entering the interacting state - InteractingStateEntered method.

For reference: https://learn.microsoft.com/en-us/uwp/api/windows.ui.composition.interactions.interactiontracker?view=winrt-26100

Testing

Updated the ScrollViewSnapSample.tsx to include onScrollEndDrag event handler and verified the console prints onScrollEndDrag when interaction with scroller stops and lnertia state enters.

Optional: Used playground-composition.sln and metro server to test my changes.

Changelog

yes

Support OnScrollBeginDrag and OnScrollEndDrag event Handling for ScrollView

Microsoft Reviewers: Open in CodeFlow

TatianaKapos · 2025-04-02T20:31:03Z

@sharath2727 Can you fill out "Add a brief summary of the change to use in the release notes for the next release." We use that to create the release notes! Example here: https://github.com/microsoft/react-native-windows/releases/tag/react-native-windows_v0.77.0

packages/playground/Samples/scrollViewSnapSample.tsx

vnext/Microsoft.ReactNative/CompositionSwitcher.idl

vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp

TatianaKapos · 2025-04-18T21:33:25Z

@sharath2727 RNW setup is a little different than other repos, we want to keep our branches clean to not clutter up the stable branches. PRs should come from your own forked repository of the react-native-windows repo, see https://github.com/microsoft/react-native-windows/blob/main/docs/contributing.md for more information! I think @Yajur-Grover also recorded some videos on how to do so!

This PR is fine but just going forward! :)

* Implement onScrollEndDrag prop * Change files * lint fix * Address comments * add noexcept * Address feedback

* Initial support for UIA and tab navigation for a child Island (#14305) * Basic support for stitching the UIA tree for a ContentIslandComponentView's child * Updated comment * Change files * Support shift+tab, and move Automation event handlers to ContentIslandComponentView * Allow portals to have independent layout constraints and scale factor (#14315) * Allow portals to have independent layout constraints and scale factor * format * change files * fix * Round Focus visuals by default, fix nudge rendering (#14312) * Round Focus visuals by default, fix nudge rendering * Change files * Fix react devtools hitting an assert on launch (#14320) * ignore unsupported methods * delete Super::DispatchCommand call * Change files * [Fabric] Fix PlatformColor (#14325) * Fix platform color * Change files * Add missing theme colors * snapshots * TurboModule spec checking should accept hstring for string arguments (#14322) * TurboModule spec checking should accept hstring for string arguments * Change files * example * Fix Number.h not copied from react-native core (#14331) ## Description ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why react-native-windows currently maintains its own forked C++ TurboModule bridging files. For untouched stuff we copy JSI and TurboModule files from core react-native in `Layout-MSRN-Headers.ps1`. However, this script misses to copy `Number.h`. This causes compilation error when trying to import `react/bridging/Bridging.h`, which would be the case for example when using codegen to generate C++ TurboModule (JSI) bindings (note: this is for C++ JSI TurboModules, not react-native-windows's TurboModule system). ``` PS C:\Users\CocoT1\Projects\rn77> yarn example windows [...] Time Elapsed 00:00:00.61 ✔ Restoring NuGet packages ✔ Auto-linking... Success: No auto-linking changes necessary. (69ms) ✔ Found Solution: C:\Users\CocoT1\Projects\rn77\example\windows\rn77Example.sln ℹ Build configuration: Debug ℹ Build platform: x64 ✖ Building Solution: Generating Code... ✖ Build failed with message 4:7>C:\Users\CocoT1\.nuget\packages\microsoft.reactnative.cxx\0.77.0-fabric\tools\Microsoft.ReactNative.Cxx\ReactCommon\react\bridging\Bridging.h(18,10): error C1083: Cannot open include file: 'react/bridging/Number.h': No such file or directory [C:\Users\CocoT1\Projects\rn77\example\windows\rn77Example\rn77Example.vcxproj]. Check your build configuration. ``` ### What I'm changing the `Layout-MSRN-Headers.ps1` script to also copy `Number.h`. I think this should be enough for the nuget the contain to file, but I'm no expert here. ## Testing Monkeypatched by copying over Number.h to the microsoft.reactnative.cxx nuget (`C:\Users\CocoT1\.nuget\packages\microsoft.reactnative.cxx\0.77.0-fabric\tools\Microsoft.ReactNative.Cxx\ReactCommon\react\bridging\`). Works all good. I don't know how to run the `Layout-MSRN-Headers.ps1` script locally. Here's a create-react-native-library project: https://github.com/hsjoberg/rnw-cxx-turbomodule Note: it will fail to build unless you copy Number.h over to the nuget cache as explained earlier. * Fix stale focus rects left in UI when last focusable component is removed (#14359) * Fix stale focus rects left in UI when last focusable component is removed * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Fix issue when calling arrange on an RN Island during load (#14362) * Fix issue when calling arrange on an RN Island during load * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Fix tooltips in high dpi (#14397) * Fix tooltips in high dpi * Change files * format * tooltips dont respect textscalefactor * Fix build issue building component codegen using clang (#14393) * Fix build issue building component codegen using clang * Change files * Components do not lose hover state if pointer leaves window before it leaves the component (#14375) * Components do not lost hover state if pointer leaves window before it leaves the component * format * Change files --------- Co-authored-by: Tatiana Kapos <[email protected]> * Property updates switching between PlatformColors would no-op (#14398) * Property updates switching between PlatformColors would no-op * Change files * format * Fix bool operator on transparent colors returning false (#14413) * Fix crash loading logbox * Fix bool operator on transparent colors returning false * Change files * format * [Fabric] Implement textAlign prop in TextInput (#14407) * Introduce support for textAlign * Add playground textinputs demonstrating textAlign * Oops, let's remove textAlignOnUpdateProps * Change files * Lint fixes * Nit * Make textAlign to be of facebook::react::TextAlignment type * Lint fixes * Don't reinvent the wheel :D * Nit: yarn format * [Fabric] Allow text components to have children (#14438) * get images/views inline with text on fabric * add back in comments * Change files * remove duplicate code * add baseline for textinput * add checks for paper vs fabric * try fixing image * add resize:none and tests * fix override * comment out test * fix tests * fix typo * try to fix tests * comment out text test * mark windows-specific changes * Allow TextInput to scroll (#14448) * Allow TextInput to scroll * Change files * update snapshot * Implement onScrollBeginDrag property for ScrollView for fabric (#14446) Implement onScrollBeginDrag property for ScrollView for fabric (#14446) * [Fabric] Implement letterSpacing for TextInput (#14460) * Implement letterSpacing for TextInput * Change files * Update react-native-windows-9ee8d633-698c-476d-9334-170be2c5dc25.json * Update textinput.tsx * optimize code * Added tooltip property for Text (#14470) * Added tooltip property in Text.windows.js TextProps.windows.js for typescript to recognise it as an attribute of Text component * Added override Text.d.ts to src-win/Libraries/Text/ to add tooltip prop to Text component * Change files * Added Sample/text for tooltip prop tests * Added TextPropsWindows to include windows specific prop tooltip * updated TextProps interface to extednd TextPropsWindows * lint fix for Sample/text.tsx file --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Add Custom Font Family in Text Input (#14495) * [Fabric] Fix Bug in Narrator Navigation (#14498) * Fix Narrator Bug * Change files * Revert Codegen Changes * Implemented on onEndEditing for TextInput component (#14489) * implemented on onEndEditing * Change files * Update textinput.tsx to remove keyboard=dismiss which actually will cause blur or lost focus implicitly * lint fixes * updated legacy textInput snapshot for component update --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Add ImageRequestParams for Image Component (#14494) * [Fabric] Implement onProgress for Image (#14493) * [Fabric] Implement SpellCheck and AutoCorrect for TextInput (#14509) * Textinput double clicking selects text (#14515) * added check for double click on textInput component view connecting it to WM_LBUTTONDBLCLK * Change files * updated for lint fix * updated to remove position( Distance check) --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Implement decelerationRate in ScrollView (#14528) * [Fabric] Implement showsVerticalScrollIndicatorValue and showsHorizontalScrollIndicatorValue for ScrollView (#14526) * SetProperties is not exposed on ReactNativeIsland (#14517) * Add SetAppProperties method to ReactNativeIsland * Change files * rename SetAppProperties to SetProperties * change file * fix * fix * [Fabric] Implement Image body in Image Source RequestImage API (#14568) * Implement body in Image Source * Change files * Add test in playground * [Fabric] Implement zoomScale, maximumZoomScale and minimumZoomScale in ScrollView (#14562) * Implemet maximumZoomScale and minimumZoomScalein ScrollView * Change files * lint fix * Add zoomScale * Implement adjustsFontSizeToFit property for Text in Fabric (#14519) * Implementation of adjustFontSizeToFit * Final Changes using TextLayout * Lint Issue Fixes * Change files * prop change detection added * review Changes and E2E test cases added * Lint and Format Changes added * Test Cases Fix added * Update SnapShot * Removed the additional Check for resizing Font * Updated SnapShot * Review Changes * Lint and Format Changes --------- Co-authored-by: Vineeth K <[email protected]> * [Fabric] Implement scrollEventThrottle for ScrollView (#14555) * Update WindowsAppSDK version to 1.7.250401001 (#14605) * Update WindowsAppSDK version to 1.7.250401001 * Change files * Update nuget lock files * more nuget lock file updates * Bump webview props * updated lock files * Implement accessibilityLevel for Fabric (#14593) * Implement accessibilityLevel for Fabric * Change files * Added Test Cases for the accessibility Label, Level etc. * Updating snapshots --------- Co-authored-by: Vineeth K <[email protected]> * [Fabric] Implement hidesWhenStopped in ActivityIndicator (#14615) * Fix: Text component pressRetentionOffset issue on Windows (#14596) * Fix: Text component pressRetentionOffset issue on Windows * Change files * lint formatting fixed --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Implement minimumFontScale in Text (#14617) * Fix InitialProps (#14620) * Fix InitialProps * Change files * [Fabric] Implement the onPressIn property for the fabric implementation of TextInput (#14480) * Implemented OnPressIn event for textinput --------- * Implement OnScrollEndDrag Event Handler for ScrollView (#14473) * Implement onScrollEndDrag prop * Change files * lint fix * Address comments * add noexcept * Address feedback * Fix : Incorrect view access to obtain ContentIsland from for the DesktopPopupSiteBridge (#14628) * solved access read violation due to incorrect view access to obtain contentIsland * rolling back text.tsx * Update end of line text.tsx * rolled back Playground-Composition.vcxproj * rolled back Playground-Composition.vcxproj * fixed lint Playground-Composition.vcxproj * master Playground-Composition.vcxproj * rolled back Playground-Composition.vcxproj * indentation fix Playground-Composition.vcxproj * Revert unintended changes in Playground-Composition.vcxproj * added patch for winUiex[erimental removal * Change files --------- Co-authored-by: Abhijeet Jha <[email protected]> Co-authored-by: Vineeth <[email protected]> * [Fabric] Implement selectTextOnFocus prop in TextInput (#14641) * fix change file type * format * Bump hermes version - enable hermes native microtasks (#14635) * Bump hermes version * Change files * Bump JSI_VERSION to 19 * Opt into microtasks * buidl fix * update playground packages.lock with the script * temp: gather crash dmp * try larger machine * Pickup microsoft/node-api-jsi#13 * Update hermes with uap nuget fix * [Fabric] Implementation of accessibiltyAnnotation and adding support for IAnnotationProvider (#14626) * Implement accessibilityAnnotation for RNW Fabric * AccessibilityAnnotation Prop implementation final changes * Playground Changes * IAnnotationProvider Implementation * Adding CompositionAnnotationProvider to the project * Adding Test Cases * Change files * Lint issue Fixes * Lint fix * Updating SnapShots * Review Changes * Updating snapshot * Properly hook up root uia provider to island (#14643) * Properly hook up root uia provider to island * Change files * Modal : Added Titlebar , title , X handling and movable for windows (#14636) * addded titlebar , title handling , X handling , resizable * Change files * lint and format fix * removed debug logs and resizable property * removed unused imports from modalHostView .cpp file * lint and format fix * Update Modal.windows.js syntax after resolve conflict * updated overrides * updated rctmodalhostview file override structure --------- Co-authored-by: Abhijeet Jha <[email protected]> * [Fabric] Implementation of accessibilityAccessKey and accessibilityItemType (#14658) * {Fabric] Implementation of accessibilityAccessKey and accessibilityItemType * Change Files * Updating snapShot * Implement CallInvoker as replacement for JSDispatcher (#14648) * Remove usage of JSDispatcher in various built-in modules * Change files * format * Implement public JSDispatcher on top of CallInvoker * format * Add ReactContext.CallInvoker and JsiInitializers * format * format * build fix * build fixes * Cleanup * Add runtime handle to instance created and instance loaded events * fix * fix * fix * fix * Remove unused JSDispatcherWriter * Bump folly to 2024.10.14.00 (#14532) * merge in folly 2024.10.14.00 * download fastfloat into node_modules * Change files * fix includes * fix cachelocality * fix desktop.dll * clean paths and fix ARM64EC * add FastFloatCommitHash to folly CGManifest * fix types * revert package.lock and fix json file path * manually fix spacing * fix * feedback * Scale loading bar text when island is super small (#14680) * Scale loading bar text when island is super small * Change files * Fix crash when reloading an instance with an active ReactNativeIsland (#14676) * Fix crash when reloading an instance with an active ReactNativeIsland * Change files * Update simple sample to use function component rather than component class * More cleanup * Fix warnings * Reenable optimization in TMs to avoid going through a dynamic for callbacks/promises (#14691) * Reenable optimization in TMs to avoid going through a dynamic for callbacks/promises * Change files * [Fabric] Implement maxFontSizeMultiplier in Text (#14622) * Clean up error messages (#14695) * Clean up error messages * Change files * JSValue exports data fields - should export value reference accessors (#14707) * JSValue shouldn't export data fields, which make it hard to use MS.RN.Cxx across dll boundaries * Change files * missing functions * fix * Fix unreferenced parameter warning in glog stub (#14708) * Fix warning in glog stub * Change files * Update folly exports from rn-win32 (#14710) * Update folly exports from rn-win32 * Change files * change files * lint fix * lint fix * update override * update snapshots * arm64ec fix * Pointer events (#14713) * PointerEvent fixes * Change files * format * Fix integration test --------- Co-authored-by: JesseCol <[email protected]> Co-authored-by: Tatiana Kapos <[email protected]> Co-authored-by: Hampus Sjöberg <[email protected]> Co-authored-by: Daniel Ayala <[email protected]> Co-authored-by: Anupriya Verma <[email protected]> Co-authored-by: Abhijeet Jha <[email protected]> Co-authored-by: Abhijeet Jha <[email protected]> Co-authored-by: Chiara Mooney <[email protected]> Co-authored-by: Vineeth <[email protected]> Co-authored-by: Vineeth K <[email protected]> Co-authored-by: Harini Malothu <[email protected]> Co-authored-by: Sharath Manchala <[email protected]>

sharath2727 added 2 commits April 2, 2025 20:02

Implement onScrollEndDrag prop

e60f368

Change files

d0c4cfc

sharath2727 requested review from a team as code owners April 2, 2025 14:53

lint fix

bef388c

sharath2727 self-assigned this Apr 2, 2025

Merge branch 'main' into user/sharath2727/scrolldrag

310e0aa

anupriya13 approved these changes Apr 3, 2025

View reviewed changes

packages/playground/Samples/scrollViewSnapSample.tsx Outdated Show resolved Hide resolved

sharath2727 requested review from jonthysell and acoates-ms April 3, 2025 07:07

chrisglein assigned jonthysell and unassigned sharath2727 Apr 3, 2025

sharath2727 requested a review from anupriya13 April 9, 2025 17:25

jonthysell requested changes Apr 9, 2025

View reviewed changes

vnext/Microsoft.ReactNative/CompositionSwitcher.idl Outdated Show resolved Hide resolved

vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp Outdated Show resolved Hide resolved

microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Apr 9, 2025

jonthysell self-requested a review April 10, 2025 23:09

Merge branch 'main' into user/sharath2727/scrolldrag

17ae413

microsoft-github-policy-service bot removed the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Apr 14, 2025

anupriya13 mentioned this pull request Apr 14, 2025

Task: Create a helper function for ScrollView metrics #14525

Closed

sharath2727 added 3 commits April 15, 2025 16:19

Address comments

437fbb8

add noexcept

e0855d2

Merge branch 'main' into user/sharath2727/scrolldrag

750a1cc

acoates-ms reviewed Apr 15, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp Outdated Show resolved Hide resolved

acoates-ms reviewed Apr 15, 2025

View reviewed changes

vnext/Microsoft.ReactNative/Fabric/Composition/ScrollViewComponentView.cpp Outdated Show resolved Hide resolved

Merge branch 'main' into user/sharath2727/scrolldrag

b354845

anupriya13 linked an issue Apr 16, 2025 that may be closed by this pull request

Task: Create a helper function for ScrollView metrics #14525

Closed

Address feedback

ad03c38

sharath2727 requested a review from acoates-ms April 18, 2025 06:12

Merge branch 'main' into user/sharath2727/scrolldrag

6c8ab81

Merge branch 'main' into user/sharath2727/scrolldrag

d539f43

acoates-ms approved these changes Apr 21, 2025

View reviewed changes

Merge branch 'main' into user/sharath2727/scrolldrag

817ed02

anupriya13 approved these changes Apr 22, 2025

View reviewed changes

sharath2727 requested review from vivekkhare31, anupriya13 and acoates-ms April 22, 2025 08:58

anupriya13 approved these changes Apr 22, 2025

View reviewed changes

Merge branch 'main' into user/sharath2727/scrolldrag

503fa4c

acoates-ms approved these changes Apr 24, 2025

View reviewed changes

jonthysell approved these changes Apr 25, 2025

View reviewed changes

sharath2727 merged commit f640c8e into main Apr 28, 2025
58 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement OnScrollEndDrag Event Handler for ScrollView #14473

Implement OnScrollEndDrag Event Handler for ScrollView #14473

Uh oh!

sharath2727 commented Apr 2, 2025 •

edited

Loading

Uh oh!

TatianaKapos commented Apr 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TatianaKapos commented Apr 18, 2025

Uh oh!

Uh oh!

Uh oh!

Implement OnScrollEndDrag Event Handler for ScrollView #14473

Implement OnScrollEndDrag Event Handler for ScrollView #14473

Uh oh!

Conversation

sharath2727 commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Why

What

Testing

Changelog

Microsoft Reviewers: Open in CodeFlow

Uh oh!

TatianaKapos commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TatianaKapos commented Apr 18, 2025

Uh oh!

Uh oh!

Uh oh!

sharath2727 commented Apr 2, 2025 •

edited

Loading

TatianaKapos commented Apr 2, 2025 •

edited

Loading