-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support further Python Interop for callables in .estimate()
, .compile()
, .run()
and .circuit()
#2091
Merged
+875
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpilation This follows up on #2054 by adding the enhanced support for Q# callables exposed into Python and Python argument arrays in resource estimation and QIR compilation.
swernli
requested review from
billti,
ivanbasov,
idavis and
minestarks
as code owners
January 6, 2025 22:42
swernli
commented
Jan 7, 2025
minestarks
reviewed
Jan 7, 2025
idavis
reviewed
Jan 8, 2025
idavis
reviewed
Jan 8, 2025
swernli
changed the title
Support further Python Interop for callables in Estimation and QIR Compilation
Support further Python Interop for callables in Jan 13, 2025
.estimate()
, .compile()
, .run()
and .circuit()
minestarks
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches what we already discussed, and all the changes seem pretty mechanical and unit tested... so I don't have a lot to pick on 😄
billti
reviewed
Jan 22, 2025
billti
reviewed
Jan 22, 2025
billti
reviewed
Jan 22, 2025
sezna
reviewed
Jan 23, 2025
sezna
reviewed
Jan 23, 2025
sezna
reviewed
Jan 23, 2025
sezna
reviewed
Jan 23, 2025
sezna
reviewed
Jan 23, 2025
sezna
reviewed
Jan 23, 2025
billti
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #2054 by adding the enhanced support for Q# callables exposed into Python and Python argument arrays in resource estimation, QIR compilation, running multiple shots, and circuit generation.