Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-core/src/tools/backend/devtools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ const annotate = defineTabTool({
const daemonArgs = [daemonScript, `--pageId=${pageId}`];

// Spawn the dashboard daemon (idempotent — the singleton socket guards against duplicates).
const daemon = spawn(process.execPath, daemonArgs, { detached: true, stdio: 'ignore' });
const daemon = spawn(process.execPath, daemonArgs, { detached: true, stdio: 'ignore', windowsHide: true });
daemon.unref();

// Spawn the annotate client in JSON mode to capture the raw payload over stdout.
Expand Down
1 change: 1 addition & 0 deletions packages/playwright-core/src/tools/cli-client/program.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ export async function program(options?: { embedderVersion?: string}) {
const child = spawn(process.execPath, daemonArgs, {
detached: !foreground,
stdio: foreground ? 'inherit' : ['pipe', 'pipe', 'ignore'],
windowsHide: true,
});
if (foreground) {
await new Promise<void>(resolve => child.on('exit', () => resolve()));
Expand Down
1 change: 1 addition & 0 deletions packages/playwright-core/src/tools/cli-client/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ export class Session {
detached: true,
stdio: ['ignore', 'pipe', err],
cwd: process.cwd(), // Will be used as root.
windowsHide: true,
});

let signalled = false;
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/processLauncher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
// Force kill the browser.
try {
if (process.platform === 'win32') {
const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true });
const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true, windowsHide: true });
const [stdout, stderr] = [taskkillProcess.stdout.toString(), taskkillProcess.stderr.toString()];
if (stdout)
options.log(`[pid=${spawnedProcess.pid}] taskkill stdout: ${stdout}`);
Expand Down
Loading