Skip to content

fix(keyboard): support audio and media control keys#39541

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Smrtnyk:media-keys
Mar 10, 2026
Merged

fix(keyboard): support audio and media control keys#39541
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Smrtnyk:media-keys

Conversation

@Smrtnyk
Copy link
Contributor

@Smrtnyk Smrtnyk commented Mar 6, 2026

Add missing audio/media key definitions to the US keyboard layout
and cover them with a page keyboard regression test.

Fixes #39533

@Smrtnyk

This comment was marked as outdated.

@Smrtnyk
Copy link
Contributor Author

Smrtnyk commented Mar 6, 2026

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Smrtnyk
Copy link
Contributor Author

Smrtnyk commented Mar 6, 2026

seems like firefox is not happy, any hints?

@cpAdm
Copy link
Contributor

cpAdm commented Mar 6, 2026

seems like firefox is not happy, any hints?

https://www.toptal.com/developers/keycode/table

  Add missing audio/media key definitions to the US keyboard layout
  and cover them with a page keyboard regression test.

  Fixes microsoft#39533
@Smrtnyk
Copy link
Contributor Author

Smrtnyk commented Mar 10, 2026

the failing proxy test on webkit seems unrelated?

@pavelfeldman pavelfeldman merged commit 1de46f5 into microsoft:main Mar 10, 2026
35 of 36 checks passed
@Smrtnyk Smrtnyk deleted the media-keys branch March 10, 2026 21:05
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/proxy.spec.ts:127 › should allow bypassing [::1] requests @webkit-ubuntu-22.04-node20

8 flaky ⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1230 › should display language-specific locators `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1230 › should display language-specific locators `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1447 › should highlight locator in iframe while typing `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:2107 › should handle failed snapshots due to dialog `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/har.spec.ts:163 › should include form params `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1230 › should display language-specific locators `@webkit-ubuntu-22.04-node20`

38932 passed, 842 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

5153 passed, 164 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't call press with AudioVolumeUp key

3 participants