test(recorder): skip flaky CDP eval test on macOS < 15 #36891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'should not lead to an error if html gets clicked' test times out on Chromium + macOS 14 due to a hanging page.evaluate call over CDP. Test passes on macOS 15, which will soon be the default in GitHub Actions for macos-latest.
dgozman
approved these changes
Aug 1, 2025
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"3 flaky46576 passed, 804 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'should not lead to an error if html gets clicked' test times out on Chromium + macOS 14 due to a hanging
page.evaluatecall over CDP. Test passes on macOS 15, which will soon (actions/runner-images#12520) be the default in GitHub Actions for macos-latest.Closes #36663
Closes #36797