feat(chromium-tip-of-tree): roll to r1318

[microsoft-playwright-automation]

BISECT RANGE: https://chromium.googlesource.com/chromium/src/+log/cda226271b95fd1207d97492cbaac6eba52d80e7..25f9b0cd65e3905fb20e0e07e1e6e385266341ba
Suspected commit: https://chromium.googlesource.com/chromium/src/+/5226d2e0acb8eba2ca19fa3b52dcaec426c671e3
Bisect command: npx bisect-chrome --good 1431790 --bad 1440183 --shell 'npm run ctest -- -x --workers=1 --reporter=list workers:240 --repeat-each 100'

• Last Good chrome-mac-1436852
• First bad chrome-mac-1436876
• Verified after bisect
• I was only able to reproduce it on macOS-Intel, probably timing related / race?!

Error:

  1) [chromium-page] › tests/page/workers.spec.ts:240:3 › should support extra http headers ────────
 
    Error: worker.evaluate: Target page, context or browser has been closed
 
      249 |   const [request2] = await Promise.all([
      250 |     server.waitForRequest('/one-style.css'),
    > 251 |     worker.evaluate(url => fetch(url), server.PREFIX + '/one-style.css'),
          |            ^
      252 |   ]);
      253 |   expect(request1.headers['foo']).toBe('bar');
      254 |   expect(request2.headers['foo']).toBe('bar');
        at /Users/max/development/playwright/tests/page/workers.spec.ts:251:12

Test:

playwright/tests/page/workers.spec.ts

Lines 240 to 255 in 67d92f0

	it('should support extra http headers', {
	annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/31747' }
	}, async ({ page, server }) => {
	await page.setExtraHTTPHeaders({ foo: 'bar' });
	const [worker, request1] = await Promise.all([
	page.waitForEvent('worker'),
	server.waitForRequest('/worker/worker.js'),
	page.goto(server.PREFIX + '/worker/worker.html'),
	]);
	const [request2] = await Promise.all([
	server.waitForRequest('/one-style.css'),
	worker.evaluate(url => fetch(url), server.PREFIX + '/one-style.css'),
	]);
	expect(request1.headers['foo']).toBe('bar');
	expect(request2.headers['foo']).toBe('bar');
	});

Investigation:

• Playwright receives Inspector.targetCrashed.
• Upstream bug: https://issues.chromium.org/u/1/issues/407795731

[github-actions]

Test results for "tests 2"

2 fatal errors, not part of any test
10 failed
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:670:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-beta-macos-latest
❌ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log @smoke @chrome-macos-latest
❌ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy @smoke @chrome-macos-latest
❌ [chromium-page] › tests/page/workers.spec.ts:240:3 › should support extra http headers @chromium-tip-of-tree-macos-13
❌ [chromium-library] › tests/library/browsercontext-events.spec.ts:19:5 › console event should work @smoke @driver
❌ [firefox-library] › tests/library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @firefox-headed-ubuntu-24.04
❌ [webkit-library] › tests/library/proxy.spec.ts:326:3 › should use http proxy for websocket requests @webkit-macos-13-large
❌ [webkit-library] › tests/library/proxy.spec.ts:326:3 › should use http proxy for websocket requests @webkit-macos-13-xlarge
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge

95 flaky

⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:686:5 › run-server › should upload large file @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1306:1 › should pick locator in iframe @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:277:5 › run-server › disconnected event should be emitted when browser is closed or server is closed @chrome-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › tests/library/logger.spec.ts:34:3 › should log context-level @chrome-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:44:3 › should use proxy for second page @chrome-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:63:3 › should work with IP:PORT notion @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:509:5 › pause › should highlight locators with custom testId @chrome-windows-latest
⚠️ [chromium-library] › tests/library/popup.spec.ts:264:3 › should not throw when click closes popup @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:643:7 › cli codegen › should select with size attribute @chromium-headed-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-headed-windows-latest
⚠️ [chromium-page] › tests/page/workers.spec.ts:25:3 › Page.workers @smoke @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › tests/page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › tests/page/workers.spec.ts:150:3 › should report network activity @chromium-tip-of-tree-macos-13--headed
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-22.04--headed
⚠️ [chromium-library] › tests/library/role-utils.spec.ts:449:5 › svg role=presentation @chromium-tip-of-tree-windows-latest
⚠️ [chromium-library] › tests/library/page-clock.spec.ts:343:3 › popup › should not run time before popup on pause @chromium-tip-of-tree-windows-latest--headed
⚠️ [chromium-page] › tests/page/page-request-continue.spec.ts:72:3 › should delete header with undefined value @chromium-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-ubuntu-22.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1559:1 › should not leak recorders @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › tests/library/video.spec.ts:187:5 › screencast › should capture static page @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:215:3 › should return cookies with empty value @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/browsercontext-route.spec.ts:155:3 › should use Set-Cookie header in future requests @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/browsercontext-route.spec.ts:199:3 › should support the times parameter with route matching @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:22:3 › SharedArrayBuffer should work @smoke @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/client-certificates.spec.ts:309:3 › browser › should fail with self-signed client certificates @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/hit-target.spec.ts:200:3 › should work with block-block-block inside inline-inline @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:399:1 › should show font preview @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1306:1 › should pick locator in iframe @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-xlarge
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @msedge-beta-ubuntu-22.04
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1231:3 › should work with connectOverCDP @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:57:5 › launch server › should default to random wsPath @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-22.04
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:162:5 › launchServer › should be able to visit ipv6 @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @msedge-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-22.04
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-library] › tests/library/signals.spec.ts:25:5 › should close the browser when the node process closes @msedge-windows-latest
⚠️ [firefox-library] › tests/library/role-utils.spec.ts:449:5 › svg role=presentation @tracing-firefox
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:424:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @tracing-webkit
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:237:7 › cli codegen › should not target selector preview by text regexp @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:237:7 › cli codegen › should not target selector preview by text regexp @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:312:7 › cli codegen › should record open in a new tab with url @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-aria.spec.ts:120:7 › should show aria snapshot error @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:23:7 › should inspect locator @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1306:1 › should pick locator in iframe @webkit-macos-13-large
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › tests/page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:228:5 › post data › should compute content-length from post data @webkit-macos-15-xlarge

241491 passed, 9402 skipped
✔️✔️✔️

Merge workflow run.

[dgozman]

Any chance the bisect is wrong, and https://chromium-review.googlesource.com/c/chromium/src/+/6374136 is the culprit?