Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture example in POM guide docs #35411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfgreffier
Copy link
Contributor

Using POM as a Playwright Test fixture is common, and fixtures are the way to go to set up tests. However the page https://playwright.dev/docs/pom has no example

  • remove Playwright Test JavaScirpt examples, like the rest of docs
  • add an example to add POM instance as fixture

Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of .js makes sense to me, but for the POM fixture we already have an example on the fixture page: https://playwright.dev/docs/test-fixtures#creating-a-fixture

Maybe we could link to that instead?

@jfgreffier
Copy link
Contributor Author

The removal of .js makes sense to me, but for the POM fixture we already have an example on the fixture page: https://playwright.dev/docs/test-fixtures#creating-a-fixture

Maybe we could link to that instead?

OK, I made the change

Skn0tt
Skn0tt previously approved these changes Apr 3, 2025
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads good to me. cc @dgozman for final review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants