Test/warning cleanups #1761
Closed
Test/warning cleanups #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Mar 17, 2025
.github/workflows/test.yml
Outdated
| @@ -12,17 +12,17 @@ env: | |||
| PW_MAX_RETRIES: 3 | |||
| jobs: | |||
| dev: | |||
| timeout-minutes: 30 | |||
| timeout-minutes: 60 | |||
There was a problem hiding this comment.
Let's do it only for channels that we know are slow?
| @@ -57,6 +57,10 @@ | |||
| <groupId>org.java-websocket</groupId> | |||
| <artifactId>Java-WebSocket</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| @@ -91,6 +92,12 @@ | |||
| <version>${websocket.version}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.slf4j</groupId> | |||
There was a problem hiding this comment.
Let's add comment that it's just for websocket to stop polluting the output with warnings.
| @@ -151,7 +158,7 @@ | |||
| <configuration> | |||
| <properties> | |||
| <configurationParameters> | |||
| junit.jupiter.execution.parallel.enabled = true | |||
| junit.jupiter.execution.parallel.enabled = false | |||
| @@ -74,6 +74,7 @@ void shouldThrowWhenBrowserPathIsInvalid(@TempDir Path tmpDir) throws NoSuchFiel | |||
| // Make sure the browsers are not installed yet by pointing at an empty dir. | |||
| env.put("PLAYWRIGHT_BROWSERS_PATH", tmpDir.toString()); | |||
| env.put("PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD", "false"); | |||
| env.put("PW_JAVA_INTERNAL_SILENT_INSTALL", "true"); | |||
There was a problem hiding this comment.
Let's not do it for now. If we do it, let's make it a public option?
mxschmitt
force-pushed
the
test/warning-cleanups
branch
from
1a11c01 to
fafef05
Compare
mxschmitt
force-pushed
the
test/warning-cleanups
branch
from
a80bbc3 to
25e478f
Compare
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PW_JAVA_INTERNAL_SILENT_INSTALLto have no confusing output in the test output - Overriding the stderr/out from inside the test does not work, since ProcessBuilder is based on file descriptors.slf4j-simplein order to get rid of:tbd. Lets see if increasing the timeouts helps to make the tests pass.