ci: expand unofficial publish-testing defaults to cover all OS/profile combinations#405
Open
martin-kolinek wants to merge 8 commits intomainfrom
Open
ci: expand unofficial publish-testing defaults to cover all OS/profile combinations#405martin-kolinek wants to merge 8 commits intomainfrom
martin-kolinek wants to merge 8 commits intomainfrom
Conversation
Until the ESRP integration lands on ox-sdk's master, run the unofficial pipeline against the experimental branch directly so we don't have to override the ox-sdk repo resource at queue time.
fb77dfb dropped to 0.0.1 in a separate commit, which made HEAD^ comparison in determine_packages skip them. Bumping to 0.0.2 in this commit ensures the ESRP experimental stage actually sees three packages and exercises the topo sort (impl -> macros -> thread_aware).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ave build evidence Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…e ESRP matrix Reverts thread_aware* back to baseline 0.6.x versions and introduces two new dependency-free crates at version 0.0.1. Both canary crates are designed to be republished by the release pipeline so the per-package ESRP fan-out (matrix) can be exercised end-to-end without affecting production crates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Removed release_canary_alpha and release_canary_beta. They existed only to exercise the multi-package ESRP matrix fan-out on the unofficial pipeline. - Re-pinned the ox-sdk pipeline resource in publish-testing.yml back to refs/heads/master and clarified the override-branch comment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the unofficial ADO publish-testing pipeline to align with the official publish pipeline defaults and to simplify iteration against the ox-sdk publishing templates.
Changes:
- Expand publish-testing validation defaults to cover both
linuxandwindows. - Expand validation profile defaults to include both
devandrelease. - Clarify (via comment) that the ox-sdk repository
refis the intended override point while keeping it pinned torefs/heads/master.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
========================================
Coverage 100.0% 100.0%
========================================
Files 224 225 +1
Lines 16187 16345 +158
========================================
+ Hits 16187 16345 +158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martin-kolinek
changed the title
martin-kolinek
changed the title
geeknoid
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to internal ox-sdk PR !5169218 — "feat(ci): introduce ESRP-based crates.io publishing".
The actual net diff vs
main(canary commits and version-bump experiments cancel out cleanly) is:.ado/pipelines/publish-testing.yml: expand the unofficial publish-testing pipeline defaults so it exercises bothlinux+windowsand bothdev+releaseprofiles. The companion ox-sdk template uses the build evidence from these jobs to drivepublish_staging/ESRP, so we want both OSes/profiles available by default on the unofficial pipeline..ado/pipelines/publish-testing.yml: clarifying comment on theox-sdkrepository resource describing it as the override point for future template iteration (kept pinned torefs/heads/master).Validation
Final green validation of the ESRP wiring on unofficial pipeline 52130 build #35261496: all stages green,
OxidizerDependencies-based "already published?" check correctly filtered known crates, matrix fan-out worked across 5 candidate crates.Merge order
master(template + steps)main(oxidizer-github pipeline tweaks)