-
Notifications
You must be signed in to change notification settings - Fork 15
ci: automatically publish github releases #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 139 139
Lines 8420 8420
=======================================
Hits 8420 8420 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is about creating release notes:
ci: automatically publish release notes #247
Yet the description is about publishing releases. What exactly is this PR meant to be about? Let's align title & description, please.
There are a workflows and script added but I see no instructions on how to use them. Feels like something is missing. It should be clear to contributors how to use the workflows and scripts we have - do we need to additionally document these in README.md or some similar place?
there is some mix up in terms, this PR enables automatic creation of github releases, which are different from publishing crates to crates.io I've manually created github releases for latest versions of the crates, but doing it manually every time a crate is published is not feasible
I can add comments into pipeline file/script, but pushing everything into common README.md seems an overkill to me |
If a user is expected to do something, it should be documented. Or are you saying these workflow + script are hands-off, never need to be executed by user? In that case a comment in the workflow/script on when/how they are executed should be sufficient, I agree. |
|
So what's the motivation for creating GitHub releases? I don't see the value for Rust crates, since crates.io is all that someone needs. Isn't this just pure overhead? If we were publishing binaries, then I think it would be useful to create releases. |
the main motivation is to publish changelog somewhere where people can actually see it |
they should be executed automatically after ADO pipeline pushes a release tag to github repo, at least this is how it's supposed to work |
|
If we are discussing the value of changelogs and how we deal with them, maybe this is a conversation we should have separate from the PR. Because IMO the value is negative and I feel cheated by having reviewed a PR that deals with publishing a resource drain! |
Please document this in the relevant workflow/script/somewhere so the context of these workflows/scripts is understandable without reverse engineering. |
120381b to
e2256d7
Compare
Adds a workflow that automatically creates releases when a new tag is pushed
example of a release: https://github.com/microsoft/oxidizer/releases/tag/uniflight-v0.1.0