Increase underhill_attestation lib unit test coverage
#635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ev dependencies for testing
persist_all_key_protectors
daprilik
reviewed
Jan 9, 2025
…ing as wrapping is by design, and remove negative test forcing overflow as debug and release behaviors are different and this test doesn't add much value
mingweishih
reviewed
Jan 10, 2025
…otector_by_id_is_empty
|
I'm not enough of an expert in this code to really comment - @mingweishih if it looks reasonable to you I'm happy to signoff. |
Yes, the tests look good to me and it's always great to increase the code coverage. Please ahead and sign it off. Thanks! |
smalis-msft
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
underhill_attestationcrate'sliblibthat don't expect aGuestEmulationTransportClientparameter (any guidance on how to construct this in a test would be appreciated)