Skip to content

ci: add job to verify binary size #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Feb 3, 2025
Merged

ci: add job to verify binary size #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
d5e1b23
first pass at adding job to verify gh binary size
justus-camp-microsoft Dec 12, 2024
3884a0f
Merge branch 'main' into verify_size
justus-camp-microsoft Dec 30, 2024
99e745b
comparison of binaries
justus-camp-microsoft Jan 2, 2025
207280e
try comparing two of what should be the same binary
justus-camp-microsoft Jan 2, 2025
40aa921
add done handle, run regen
justus-camp-microsoft Jan 2, 2025
f7ffdcb
fmt so that ci will actually run
justus-camp-microsoft Jan 2, 2025
9853a16
clippy
justus-camp-microsoft Jan 2, 2025
e9854fa
fix command line argument
justus-camp-microsoft Jan 2, 2025
12c39aa
swap old and new position
justus-camp-microsoft Jan 3, 2025
7fe1ab7
try to download hardcoded artifact
justus-camp-microsoft Jan 3, 2025
17ac9d5
remove wrong parameter, clippy
justus-camp-microsoft Jan 3, 2025
9b47097
get merge head to run size check with
justus-camp-microsoft Jan 6, 2025
e9108a5
output error
justus-camp-microsoft Jan 6, 2025
51cb2a3
get stdout and stderr to debug ci issue
justus-camp-microsoft Jan 6, 2025
bc7963e
try getting stderr again
justus-camp-microsoft Jan 6, 2025
a0f9c0d
another attempt at getting git merge-base output
justus-camp-microsoft Jan 6, 2025
d7c38a5
fix build and format
justus-camp-microsoft Jan 6, 2025
77167e0
print git status
justus-camp-microsoft Jan 6, 2025
40363c4
get head ref from github context variable
justus-camp-microsoft Jan 6, 2025
4f01015
write merge commit to variable
justus-camp-microsoft Jan 6, 2025
e17187d
still need to be in checked out repo
justus-camp-microsoft Jan 6, 2025
ce02bdc
change gh context variable
justus-camp-microsoft Jan 6, 2025
1538c7c
build
justus-camp-microsoft Jan 6, 2025
b9c3536
try fetch depth of 0
justus-camp-microsoft Jan 7, 2025
ecb554a
try getting fetch depth 0 again
justus-camp-microsoft Jan 7, 2025
b4811dc
Merge branch 'main' into verify_size
justus-camp-microsoft Jan 7, 2025
e4df6d7
roundabout way of fetching pr branch hopefully
justus-camp-microsoft Jan 7, 2025
b6bed7a
hack in the gh token
justus-camp-microsoft Jan 7, 2025
eea8ab6
run shell from right directory
justus-camp-microsoft Jan 7, 2025
c6881b3
print file tree to debug
justus-camp-microsoft Jan 7, 2025
584f248
try to fix binary path
justus-camp-microsoft Jan 7, 2025
8a01cfb
actually fix path
justus-camp-microsoft Jan 7, 2025
4ac364d
fmt
justus-camp-microsoft Jan 7, 2025
2d1bf6e
another path change...
justus-camp-microsoft Jan 7, 2025
46968a8
try to run a release build as part of PR pipeline
justus-camp-microsoft Jan 7, 2025
3d00b0d
loop through commits
justus-camp-microsoft Jan 7, 2025
0711d49
use gh cli to comment on PR
justus-camp-microsoft Jan 7, 2025
2fc057a
try adding pr write permissions
justus-camp-microsoft Jan 8, 2025
1a6c341
Revert "try adding pr write permissions"
justus-camp-microsoft Jan 8, 2025
2acb5be
Revert "use gh cli to comment on PR"
justus-camp-microsoft Jan 8, 2025
b1f5fa6
more rigorous size diff
justus-camp-microsoft Jan 8, 2025
5a537f2
clippy
justus-camp-microsoft Jan 8, 2025
91e390a
Merge branch 'main' into verify_size
justus-camp-microsoft Jan 8, 2025
ad99ffc
misc fixes
justus-camp-microsoft Jan 8, 2025
ffbcee7
fetch main?
justus-camp-microsoft Jan 8, 2025
ef5977c
Merge branch 'main' into verify_size
justus-camp-microsoft Jan 10, 2025
2f8d4b5
Merge branch 'main' into verify_size
Jan 29, 2025
531efd3
some comments
Jan 29, 2025
e88cbd2
some more comments, fix type of pr number
Jan 29, 2025
c6915e9
merge into one step, hopefully fix gh_cli issue
Jan 29, 2025
9be44a9
try another xshell cmd to get around macro not working properly
Jan 29, 2025
d904298
opt into object's std feature, use context
Jan 30, 2025
af00ead
with_context instead of context
Jan 30, 2025
763b746
some of PR feedback
Jan 30, 2025
d99589b
some more cleanup
Jan 30, 2025
4819b9e
fix cmd macro
Jan 30, 2025
830acb5
only upload baseline artifact for x64 ship builds
justus-camp-microsoft Jan 31, 2025
a06a673
log comparison commit
jstarks Jan 31, 2025
850a8d3
Merge pull request #4 from jstarks/verify_size
justus-camp-microsoft Jan 31, 2025
30576ca
some of comments
justus-camp-microsoft Jan 31, 2025
b416ed6
new node for size comparison baseline
justus-camp-microsoft Jan 31, 2025
df679b1
Merge remote-tracking branch 'upstream/main' into verify_size
justus-camp-microsoft Jan 31, 2025
4b45e65
clippy
justus-camp-microsoft Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 74 additions & 15 deletions .github/workflows/openvmm-ci.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading