openhcl servicing: fix breaking servicing state change for optional vmgs #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-oo
reviewed
Jul 16, 2025
| @@ -84,6 +84,8 @@ mod state { | |||
| pub dma_manager_state: Option<OpenhclDmaManagerState>, | |||
| #[mesh(10002)] | |||
| pub vmbus_client: Option<vmbus_client::SavedState>, | |||
| #[mesh(10003)] | |||
| pub use_vmgs: bool, | |||
There was a problem hiding this comment.
should we use an enum or bool for future compatability, or do we not think we will need anything else?
chris-oo
reviewed
Jul 16, 2025
| }), | ||
| }, | ||
| disk_get_vmgs::save_restore::SavedBlockStorageMetadata { | ||
| capacity: u64::MAX, |
There was a problem hiding this comment.
i feel like MAX is worse than 0 for some of these values? IE sizes and count seem like 0 should be better?
|
We have decided not to change this, since it won't be hit in any current production scenarios and we need a way to reject servicing to an older version if new features are enabled anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenHCL now supports ephemeral guest state, VMGS saved state is now optional. This change fixes servicing state backwards compatibility by using a separate bool and bogus values instead of an actual optional.