WIP: Add VPCI relay #1349
Draft
WIP: Add VPCI relay #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtikoo
reviewed
May 26, 2025
| use std::sync::Arc; | ||
| use vpci_client::VpciDevice; | ||
|
|
||
| pub struct RelayedVpciDevice(Arc<VpciDevice>); |
There was a problem hiding this comment.
Seems like this struct and impl is duplicated in openhcl/underhill_core/src/vpci_relay.rs?
vtikoo
reviewed
May 26, 2025
| .await?; | ||
| // TODO: hang onto this guy, wire him up to the inspect graph at least. | ||
| vpci_client.detach(); | ||
| let vpci_device = Arc::new(devices_recv.next().await.context("no device")?); |
There was a problem hiding this comment.
Could you confirm if this consumes all devices enumerated by VpciClientWorker task?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay VPCI interactions through OpenHCL so that we can filter devices and
manipulate configuration space.