Skip to content

change dependency from gitlab eigen to github eigen-mirror #24884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2025

Conversation

prathikr
Copy link
Contributor

@prathikr prathikr commented May 28, 2025

Fix for #24861

guschmue
guschmue previously approved these changes May 28, 2025
@prathikr prathikr requested a review from guschmue May 28, 2025 17:00
@prathikr prathikr changed the title adjust checksum to match expected checksum of eigen dependency change dependency from gitlab eigen to github eigen-mirror May 28, 2025
@prathikr prathikr requested review from fs-eire and snnn May 28, 2025 18:33
snnn
snnn previously approved these changes May 28, 2025
fs-eire
fs-eire previously approved these changes May 28, 2025
@prathikr prathikr dismissed stale reviews from fs-eire and snnn via 4ba0ef5 May 28, 2025 22:28
@prathikr prathikr requested review from snnn and fs-eire May 28, 2025 22:28
@prathikr prathikr merged commit f57db79 into main May 29, 2025
88 checks passed
@prathikr prathikr deleted the prathikrao/eigen-checksum-bugfix branch May 29, 2025 23:09
@BengtGustafsson
Copy link
Contributor

So now we need a fully tested 1.22.1 tag that we can actually build immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants